-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Upgrade kdp #996
[WIP] Upgrade kdp #996
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maqiuyujoyce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
||
replace github.com/GoogleCloudPlatform/k8s-config-connector => ./ | ||
|
||
replace github.com/maqiuyujoyce/k8s-config-connector => ./ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you haven't seen workspaces: https://go.dev/doc/tutorial/workspaces
) | ||
|
||
func GetMockClient(t *testing.T) client.Client { | ||
k8s, err := mockkubeapiserver.NewMockKubeAPIServer(":http") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use :0
to get a dynamic port allocation
} | ||
|
||
mgr, err := manager.New(restConfig, manager.Options{ | ||
Scheme: runtime.NewScheme(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HealthProbeBindAddress: "0",
MetricsBindAddress: "0",
to turn off the servers, which I think were causing the port conflict
Change description
Fixes #
Tests you have done
make ready-pr
to ensure this PR is ready for review.