Fix vulnerabilities by upgrading dependencies #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatherineF-dev
commented
Apr 24, 2024
CatherineF-dev
force-pushed
the
vul
branch
2 times, most recently
from
f40432d
to
daec96e
Compare
|
Have some unit test failures, will update test codes. |
leonzz
reviewed
Apr 24, 2024
leonzz
approved these changes
Apr 24, 2024
custom-metrics-stackdriver-adapter/pkg/adapter/coreprovider/provider.go
Outdated
Show resolved
Hide resolved
CatherineF-dev
force-pushed
the
vul
branch
2 times, most recently
from
572db32
to
302409b
Compare
|
/retest |
|
/retest |
|
/hold Need to wait another dependency fix. kubernetes-sigs/custom-metrics-apiserver#171 |
|
Tested locally, got error |
CatherineF-dev
force-pushed
the
vul
branch
2 times, most recently
from
c72bd1e
to
be6f0ac
Compare
Upgrade custom-metrics-apiserver
Update Add unit tests Update comment
|
Tested it can work. Annotations: <none>
Namespace: default
Labels: <none>
Annotations: <none>
CreationTimestamp: Mon, 29 Apr 2024 17:31:33 +0000
Reference: Deployment/custom-metric-sd
Metrics: ( current / target )
"custom-metric" on pods: 40 / 20
Min replicas: 1
Max replicas: 5
Deployment pods: 2 current / 2 desired
Conditions:
Type Status Reason Message
---- ------ ------ -------
AbleToScale True ReadyForNewScale recommended size matches current size
ScalingActive True ValidMetricFound the HPA was able to successfully calculate a replica count from pods metric custom-metric
ScalingLimited False DesiredWithinRange the desired count is within the acceptable range
Events: <none> |
|
Discussed offline, leonzz has LGTMed. Will merge. |
This was referenced Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/hold