This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Remove reference to standalone cobra cli #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmcb
suggested changes
Mar 5, 2022
| @@ -28,7 +28,7 @@ clean() { | |||
| } | |||
|
|
|||
| build_proto_files(){ | |||
| go get -u -v github.com/spf13/cobra/cobra && \ | |||
| go get -u -v github.com/spf13/cobra && \ | |||
There was a problem hiding this comment.
Shouldn't this be
- go get -u -v github.com/spf13/cobra/cobra && \
+ go get -u -v github.com/spf13/cobra-cli && \?
There was a problem hiding this comment.
I don't think so. From what I can tell, this is trying to fetch the dependencies needed to compile, and that is only the cobra lib. It just happened to fetch the parent lib as a side effect before
There was a problem hiding this comment.
this is trying to fetch the dependencies needed to compile
Ah that makes sense 👍🏼
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the
go getcommand to use the cobra library instead of thecobra/cobracommand, since the command is being removed from the github.com/spf13/cobra module (xref spf13/cobra#1597)