feat: samples for Confluent operator tutorial

[ganochenkodg]

No description provided.

[snippet-bot]

Here is the summary of changes.

You are about to add 10 region tags.

• streaming/kafka-confluent/terraform/gke-autopilot/main.tf:25, tag gke_streaming_kafka_confluent_autopilot_private_regional_cluster
• streaming/kafka-confluent/terraform/gke-replicator/main.tf:26, tag gke_streaming_kafka_confluent_standard_private_regional_cluster
• streaming/kafka-confluent/terraform/gke-standard/main.tf:25, tag gke_streaming_kafka_confluent_standard_private_regional_cluster
• streaming/kafka-confluent/terraform/modules/cluster-autopilot/main.tf:15, tag gke_streaming_kafka_confluent_autopilot_private_regional_cluster
• streaming/kafka-confluent/terraform/modules/cluster-replicator/main.tf:15, tag gke_streaming_kafka_confluent_standard_private_regional_cluster
• streaming/kafka-confluent/terraform/modules/cluster/main.tf:15, tag gke_streaming_kafka_confluent_standard_private_regional_cluster
• streaming/kafka-confluent/terraform/modules/network-replicator/main.tf:15, tag gke_streaming_kafka_confluent_vpc_multi_region_network
• streaming/kafka-confluent/terraform/modules/network-replicator/main.tf:95, tag gke_streaming_kafka_confluent_cloudnat_simple_create
• streaming/kafka-confluent/terraform/modules/network/main.tf:15, tag gke_streaming_kafka_confluent_vpc_multi_region_network
• streaming/kafka-confluent/terraform/modules/network/main.tf:56, tag gke_streaming_kafka_confluent_cloudnat_simple_create

---

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

• Refresh this comment

[NimJay]

Issue:
The /streaming/kafka-confluent/terraform folder and its contents that we're adding in this pull-request is mostly identical to the existing /streaming/kafka-strimzi/terraform folder and its contents. Could we please reduce this duplication (all or most)? For instance, could we reuse the existing /streaming/kafka-strimzi/terraform/ directory and consider moving /streaming/kafka-confluent/terraform/ to a new folder /streaming/kafka/terraform/ (so that it's clear that it's not Strimzi-specific)?

[ganochenkodg]

Well, the only difference in tf code is terraform tags (could be the same, it doesn't matter), the "component" label for the cluster (can fix with component = "strimzi-operator" -> component = "${var.cluster_prefix}-operator") and ingress rule for replicator (different ports, can add both in the rule to work with any operator)
@aburhan @NimJay your opinion?

Also these changes will affect the documentation, so i will need to fix Basic and Replication guides

[aburhan]

@ganochenkodg I think its a good idea to pull out the terraform into its own folder as @NimJay mentioned since the code is identical (/streaming/kafka/terraform/). The manifest files for each are different so we can have operator specific folders for those manifests under streaming/kafka/confluent. I work later to rework the strimzi files

[ganochenkodg]

Then i'll create an additional PR with only these changes and let you know

[NimJay]

Thanks, you two, for working toward removing Terraform duplication.
As discussed with @aburhan, we can merge this pull-request as is (without the Terraform refactoring).
I've opened #861 to track the duplication issue.

@ganochenkodg if you want, you can just move the /streaming/kafka-confluent/terraform/ folder to /streaming/kafka/terraform/, and we can worry about updating the Strimzi tutorial later. Or merge as is.

[NimJay]

Hi @ganochenkodg,

Thank you so much for these samples.
(And sorry about the late review!)
I just have two immediate concerns/questions:

1. For Kafka/Confluent-related issues, do we have a Googler that can debug any issues/bugs we'll encounter in these samples (in the future)?
2. See my other comment about reducing Terraform duplication.

I have not tested these samples myself, but I trust you or the tech writers (or another sample author) have/will do the appropriate testing before publishing these samples.

Thanks again! :)

[ganochenkodg]

@aburhan

For Kafka/Confluent-related issues, do we have a Googler that can debug any issues/bugs we'll encounter in these samples (in the future)?

What do you think?

[aburhan]

@aburhan

For Kafka/Confluent-related issues, do we have a Googler that can debug any issues/bugs we'll encounter in these samples (in the future)?

What do you think?

@NimJay I will be responsible for issues and bugs in the future

[NimJay]

Note: If the cla/google check is failing because of my personal email address, please ignore it (i.e., feel free to merge).
It's currently (at the time of commenting) passing because I have requested an override via Google-internal link: go/gh-prinfo. But it will fail again if a new commit is added.
Sorry for the inconvenience!

[NimJay]

Thanks again, @ganochenkodg and @aburhan, for your patience here (and for creating these samples!).
Approved. Feel free to merge.