Move more billing tests that require permissions beyond Billing User …

…to master billing account
GoogleCloudPlatform · Feb 24, 2023 · 0f92e94 · 0f92e94
1 parent dbb7da0
commit 0f92e94
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/mmv1/third_party/terraform/tests/data_source_google_billing_account_test.go b/mmv1/third_party/terraform/tests/data_source_google_billing_account_test.go
@@ -9,7 +9,7 @@ import (
 )
 
 func TestAccDataSourceGoogleBillingAccount_byFullName(t *testing.T) {
-	billingId := getTestBillingAccountFromEnv(t)
+	billingId := getTestMasterBillingAccountFromEnv(t)
 	name := "billingAccounts/" + billingId
 
 	vcrTest(t, resource.TestCase{
@@ -29,7 +29,7 @@ func TestAccDataSourceGoogleBillingAccount_byFullName(t *testing.T) {
 }
 
 func TestAccDataSourceGoogleBillingAccount_byShortName(t *testing.T) {
-	billingId := getTestBillingAccountFromEnv(t)
+	billingId := getTestMasterBillingAccountFromEnv(t)
 	name := "billingAccounts/" + billingId
 
 	vcrTest(t, resource.TestCase{
@@ -49,7 +49,7 @@ func TestAccDataSourceGoogleBillingAccount_byShortName(t *testing.T) {
 }
 
 func TestAccDataSourceGoogleBillingAccount_byFullNameClosed(t *testing.T) {
-	billingId := getTestBillingAccountFromEnv(t)
+	billingId := getTestMasterBillingAccountFromEnv(t)
 	name := "billingAccounts/" + billingId
 
 	vcrTest(t, resource.TestCase{

diff --git a/mmv1/third_party/terraform/tests/resource_logging_bucket_config_test.go b/mmv1/third_party/terraform/tests/resource_logging_bucket_config_test.go
@@ -131,7 +131,7 @@ func TestAccLoggingBucketConfigBillingAccount_basic(t *testing.T) {
 
 	context := map[string]interface{}{
 		"random_suffix":        randString(t, 10),
-		"billing_account_name": "billingAccounts/" + getTestBillingAccountFromEnv(t),
+		"billing_account_name": "billingAccounts/" + getTestMasterBillingAccountFromEnv(t),
 		"org_id":               getTestOrgFromEnv(t),
 	}