populate external_ipv6 (#6244)

Co-authored-by: Edward Sun <sunedward@google.com>
GoogleCloudPlatform · Jul 11, 2022 · 12ba99e · 12ba99e
1 parent 4aecac1
commit 12ba99e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/mmv1/third_party/terraform/tests/resource_compute_instance_test.go.erb b/mmv1/third_party/terraform/tests/resource_compute_instance_test.go.erb
@@ -268,6 +268,7 @@ func TestAccComputeInstance_IPv6(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckComputeInstanceExists(
 						t, "google_compute_instance.foobar", &instance),
+					testAccCheckComputeInstanceIpv6AccessConfigHasExternalIPv6(&instance),
 				),
 			},
 			{
@@ -2545,6 +2546,20 @@ func testAccCheckComputeInstanceAccessConfigHasNatIP(instance *compute.Instance)
 	}
 }
 
+func testAccCheckComputeInstanceIpv6AccessConfigHasExternalIPv6(instance *compute.Instance) resource.TestCheckFunc {
+	return func(s *terraform.State) error {
+		for _, i := range instance.NetworkInterfaces {
+			for _, c := range i.Ipv6AccessConfigs {
+				if c.ExternalIpv6 == "" {
+					return fmt.Errorf("no External IPv6")
+				}
+			}
+		}
+
+		return nil
+	}
+}
+
 func testAccCheckComputeInstanceAccessConfigHasPTR(instance *compute.Instance) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
 		for _, i := range instance.NetworkInterfaces {

diff --git a/mmv1/third_party/terraform/utils/compute_instance_helpers.go.erb b/mmv1/third_party/terraform/utils/compute_instance_helpers.go.erb
@@ -180,6 +180,7 @@ func flattenIpv6AccessConfigs(ipv6AccessConfigs []*compute.AccessConfig) []map[s
 			"network_tier": ac.NetworkTier,
 		}
 		flattened[i]["public_ptr_domain_name"] = ac.PublicPtrDomainName
+		flattened[i]["external_ipv6"] = ac.ExternalIpv6
 	}
 	return flattened
 }