add tests and refactor

GoogleCloudPlatform · Aug 23, 2023 · 1dc0224 · 1dc0224
1 parent 73d26ed
commit 1dc0224
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/mmv1/templates/terraform/examples/iam_workforce_pool_provider_oidc_basic.tf.erb b/mmv1/templates/terraform/examples/iam_workforce_pool_provider_oidc_basic.tf.erb
@@ -22,7 +22,6 @@ resource "google_iam_workforce_pool_provider" "<%= ctx[:primary_resource_id] %>"
     web_sso_config {
       response_type             = "CODE"
       assertion_claims_behavior = "MERGE_USER_INFO_OVER_ID_TOKEN_CLAIMS"
-      additional_scopes         = "groups"
     }
   }
 }
diff --git a/mmv1/templates/terraform/examples/iam_workforce_pool_provider_oidc_full.tf.erb b/mmv1/templates/terraform/examples/iam_workforce_pool_provider_oidc_full.tf.erb
@@ -22,7 +22,7 @@ resource "google_iam_workforce_pool_provider" "<%= ctx[:primary_resource_id] %>"
     web_sso_config {
       response_type             = "CODE"
       assertion_claims_behavior = "MERGE_USER_INFO_OVER_ID_TOKEN_CLAIMS"
-      additional_scopes         = "groups"
+      additional_scopes         = ["groups"]
     }
   }
   display_name        = "Display name"

diff --git a/...arty/terraform/services/iamworkforcepool/resource_iam_workforce_pool_provider_test.go.erb b/...arty/terraform/services/iamworkforcepool/resource_iam_workforce_pool_provider_test.go.erb
@@ -180,6 +180,7 @@ resource "google_iam_workforce_pool_provider" "my_provider" {
     web_sso_config {
       response_type             = "CODE"
       assertion_claims_behavior = "MERGE_USER_INFO_OVER_ID_TOKEN_CLAIMS"
+      additional_scopes         = ["groups"]
     }
   }
   display_name        = "Display name"
@@ -216,6 +217,7 @@ resource "google_iam_workforce_pool_provider" "my_provider" {
     web_sso_config {
       response_type             = "ID_TOKEN"
       assertion_claims_behavior = "ONLY_ID_TOKEN_CLAIMS"
+      additional_scopes         = ["groups"]
     }
   }
   display_name        = "New Display name"
@@ -247,6 +249,7 @@ resource "google_iam_workforce_pool_provider" "my_provider" {
     web_sso_config {
       response_type             = "ID_TOKEN"
       assertion_claims_behavior = "ONLY_ID_TOKEN_CLAIMS"
+      additional_scopes         = ["groups"]
     }
   }
   display_name        = "New Display name"