Skip to content

Commit

Permalink
Use API response for retainedReleaseCount
Browse files Browse the repository at this point in the history
  • Loading branch information
rainshen49 committed Nov 7, 2022
1 parent a9579e9 commit 51e62b2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 0 additions & 1 deletion mmv1/products/firebasehosting/api.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ objects:
description: |
The number of previous releases to retain on the channel for rollback or other
purposes. Must be a number between 1-100. Defaults to 10 for new channels.
default_value: 10
- !ruby/object:Api::Type::KeyValuePairs
name: labels
description: Text labels used for extra metadata and/or filtering
Expand Down
2 changes: 2 additions & 0 deletions mmv1/products/firebasehosting/terraform.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ overrides: !ruby/object:Overrides::ResourceOverrides
properties:
expireTime: !ruby/object:Overrides::Terraform::PropertyOverride
default_from_api: true # API computes value from ttl if not set directly
retainedReleaseCount: !ruby/object:Overrides::Terraform::PropertyOverride
default_from_api: true # unlimited for "live" channel created with the site, and 10 for subsequent channels
ttl: !ruby/object:Overrides::Terraform::PropertyOverride
ignore_read: true # API doesn't return this value
examples:
Expand Down

0 comments on commit 51e62b2

Please sign in to comment.