Skip to content

Commit

Permalink
Review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
rileykarson committed Sep 17, 2019
1 parent 69235e3 commit 5735541
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -777,7 +777,7 @@ resource "google_container_node_pool" "np" {
cluster = "${google_container_cluster.cluster.name}"

initial_node_count = 1
node_locations = ["us-central1-a", "us-central1-c"]
node_locations = ["us-central1-a", "us-central1-c"]
}`, cluster, cluster, np)
}
<% end -%>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,11 @@ this will force recreation of the resource.
See the [official documentation](https://cloud.google.com/kubernetes-engine/docs/how-to/flexible-pod-cidr)
for more information.

* `node_locations` - (Optional) The list of zones in which the node pool's nodes
should be located. Nodes must be in the region of their regional cluster or in
the same region as their cluster's zone for zonal clusters. If unspecified, the
cluster-level `node_locations` will be used.
* `node_locations` - (Optional, [Beta](https://terraform.io/docs/providers/google/provider_versions.html))
The list of zones in which the node pool's nodes should be located. Nodes must
be in the region of their regional cluster or in the same region as their
cluster's zone for zonal clusters. If unspecified, the cluster-level
`node_locations` will be used.

-> Note: `node_locations` will not revert to the cluster's default set of zones
upon being unset. You must manually reconcile the list of zones with your
Expand Down

0 comments on commit 5735541

Please sign in to comment.