Add "inbound_services" to google_app_engine_standard_app_version (#3537)

GoogleCloudPlatform · Jun 2, 2020 · 7803d55 · 7803d55
1 parent 51d183e
commit 7803d55
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/products/appengine/api.yaml b/products/appengine/api.yaml
@@ -457,6 +457,11 @@ objects:
             required: true
             description: |
               The format should be a shell command that can be fed to bash -c.
+      - !ruby/object:Api::Type::Array
+        name: 'inboundServices'
+        description: |
+          Before an application can receive email or XMPP messages, the application must be configured to enable the service.
+        item_type: Api::Type::String
       - !ruby/object:Api::Type::String
         name: 'instanceClass'
         description: |

diff --git a/products/appengine/terraform.yaml b/products/appengine/terraform.yaml
@@ -65,6 +65,8 @@ overrides: !ruby/object:Overrides::ResourceOverrides
       # instanceClass defaults to a value based on the scaling method
       instanceClass: !ruby/object:Overrides::Terraform::PropertyOverride
         default_from_api: true
+      inboundServices: !ruby/object:Overrides::Terraform::PropertyOverride
+        is_set: true
     examples:
       - !ruby/object:Provider::Terraform::Examples
         name: "app_engine_standard_app_version"
@@ -127,6 +129,8 @@ overrides: !ruby/object:Overrides::ResourceOverrides
         default_from_api: true
       handlers: !ruby/object:Overrides::Terraform::PropertyOverride
         default_from_api: true
+      inboundServices: !ruby/object:Overrides::Terraform::PropertyOverride
+        is_set: true
     examples:
       - !ruby/object:Provider::Terraform::Examples
         name: "app_engine_flexible_app_version"

diff --git a/third_party/terraform/tests/resource_app_engine_standard_app_version_test.go b/third_party/terraform/tests/resource_app_engine_standard_app_version_test.go
@@ -84,6 +84,8 @@ resource "google_app_engine_standard_app_version" "foo" {
     }
   }
 
+  inbound_services = ["INBOUND_SERVICE_WARMUP", "INBOUND_SERVICE_MAIL"]
+
   env_variables = {
     port = "8000"
   }
@@ -168,6 +170,8 @@ resource "google_app_engine_standard_app_version" "foo" {
     }
   }
 
+  inbound_services = []
+
   env_variables = {
     port = "8000"
   }