Skip to content

Commit

Permalink
remove max_pods_per_node exclude from remaining tests.
Browse files Browse the repository at this point in the history
  • Loading branch information
@nat-henderson
nat-henderson committed Oct 7, 2019
1 parent 905e4fc commit 84c252d
Showing 1 changed file with 2 additions and 20 deletions.
22 changes: 2 additions & 20 deletions third_party/terraform/tests/resource_container_node_pool_test.go.erb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,6 @@ func TestAccContainerNodePool_withGPU(t *testing.T) {
ResourceName: "google_container_node_pool.np_with_gpu",
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"max_pods_per_node"},
},
},
})
Expand Down Expand Up @@ -327,7 +326,6 @@ func TestAccContainerNodePool_withManagement(t *testing.T) {
ResourceName: "google_container_node_pool.np_with_management",
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"max_pods_per_node"},
},
resource.TestStep{
Config: testAccContainerNodePool_withManagement(cluster, nodePool, management),
Expand All @@ -344,7 +342,6 @@ func TestAccContainerNodePool_withManagement(t *testing.T) {
ResourceName: "google_container_node_pool.np_with_management",
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"max_pods_per_node"},
},
},
})
Expand All @@ -365,7 +362,6 @@ func TestAccContainerNodePool_withNodeConfigScopeAlias(t *testing.T) {
ResourceName: "google_container_node_pool.np_with_node_config_scope_alias",
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"max_pods_per_node"},
},
},
})
Expand Down Expand Up @@ -394,7 +390,6 @@ func TestAccContainerNodePool_regionalAutoscaling(t *testing.T) {
ResourceName: "google_container_node_pool.np",
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"max_pods_per_node"},
},
resource.TestStep{
Config: testAccContainerNodePool_updateAutoscaling(cluster, np),
Expand All @@ -407,7 +402,6 @@ func TestAccContainerNodePool_regionalAutoscaling(t *testing.T) {
ResourceName: "google_container_node_pool.np",
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"max_pods_per_node"},
},
resource.TestStep{
Config: testAccContainerNodePool_basic(cluster, np),
Expand All @@ -422,7 +416,7 @@ func TestAccContainerNodePool_regionalAutoscaling(t *testing.T) {
ImportStateVerify: true,
// autoscaling.# = 0 is equivalent to no autoscaling at all,
// but will still cause an import diff
ImportStateVerifyIgnore: []string{"autoscaling.#", "max_pods_per_node"},
ImportStateVerifyIgnore: []string{"autoscaling.#"},
},
},
})
Expand Down Expand Up @@ -450,7 +444,6 @@ func TestAccContainerNodePool_autoscaling(t *testing.T) {
ResourceName: "google_container_node_pool.np",
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"max_pods_per_node"},
},
resource.TestStep{
Config: testAccContainerNodePool_updateAutoscaling(cluster, np),
Expand All @@ -463,7 +456,6 @@ func TestAccContainerNodePool_autoscaling(t *testing.T) {
ResourceName: "google_container_node_pool.np",
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"max_pods_per_node"},
},
resource.TestStep{
Config: testAccContainerNodePool_basic(cluster, np),
Expand All @@ -478,7 +470,7 @@ func TestAccContainerNodePool_autoscaling(t *testing.T) {
ImportStateVerify: true,
// autoscaling.# = 0 is equivalent to no autoscaling at all,
// but will still cause an import diff
ImportStateVerifyIgnore: []string{"autoscaling.#", "max_pods_per_node"},
ImportStateVerifyIgnore: []string{"autoscaling.#"},
},
},
})
Expand All @@ -505,7 +497,6 @@ func TestAccContainerNodePool_resize(t *testing.T) {
ResourceName: "google_container_node_pool.np",
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"max_pods_per_node"},
},
{
Config: testAccContainerNodePool_resize(cluster, np),
Expand All @@ -517,7 +508,6 @@ func TestAccContainerNodePool_resize(t *testing.T) {
ResourceName: "google_container_node_pool.np",
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"max_pods_per_node"},
},
},
})
Expand All @@ -541,7 +531,6 @@ func TestAccContainerNodePool_version(t *testing.T) {
ResourceName: "google_container_node_pool.np",
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"max_pods_per_node"},
},
{
Config: testAccContainerNodePool_updateVersion(cluster, np),
Expand All @@ -550,7 +539,6 @@ func TestAccContainerNodePool_version(t *testing.T) {
ResourceName: "google_container_node_pool.np",
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"max_pods_per_node"},
},
{
Config: testAccContainerNodePool_version(cluster, np),
Expand All @@ -559,7 +547,6 @@ func TestAccContainerNodePool_version(t *testing.T) {
ResourceName: "google_container_node_pool.np",
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"max_pods_per_node"},
},
},
})
Expand All @@ -583,7 +570,6 @@ func TestAccContainerNodePool_regionalClusters(t *testing.T) {
ResourceName: "google_container_node_pool.np",
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"max_pods_per_node"},
},
},
})
Expand All @@ -607,7 +593,6 @@ func TestAccContainerNodePool_012_ConfigModeAttr(t *testing.T) {
ResourceName: "google_container_node_pool.np",
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"max_pods_per_node"},
},
{
Config: testAccContainerNodePool_012_ConfigModeAttr2(cluster, np),
Expand All @@ -616,7 +601,6 @@ func TestAccContainerNodePool_012_ConfigModeAttr(t *testing.T) {
ResourceName: "google_container_node_pool.np",
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"max_pods_per_node"},
},
},
})
Expand All @@ -641,7 +625,6 @@ func TestAccContainerNodePool_EmptyGuestAccelerator(t *testing.T) {
ResourceName: "google_container_node_pool.np",
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"max_pods_per_node"},
},
{
// Test alternative way to specify an empty node pool
Expand All @@ -651,7 +634,6 @@ func TestAccContainerNodePool_EmptyGuestAccelerator(t *testing.T) {
ResourceName: "google_container_node_pool.np",
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"max_pods_per_node"},
},
{
// Assert that changes in count from 1 result in a diff
Expand Down

0 comments on commit 84c252d

Please sign in to comment.