Add mutex to compute_project_metadata_item (#4778)

Co-authored-by: Chris Tomlinson <chris.tomlinson@dunnhumby.com>
GoogleCloudPlatform · May 17, 2021 · 999bcfa · 999bcfa
1 parent 4cc73d1
commit 999bcfa
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/mmv1/third_party/terraform/resources/resource_compute_project_metadata_item.go b/mmv1/third_party/terraform/resources/resource_compute_project_metadata_item.go
@@ -170,6 +170,10 @@ func resourceComputeProjectMetadataItemDelete(d *schema.ResourceData, meta inter
 
 func updateComputeCommonInstanceMetadata(config *Config, projectID, key, userAgent string, afterVal *string, timeout time.Duration, failIfPresent metadataPresentBehavior) error {
 	updateMD := func() error {
+		lockName := fmt.Sprintf("projects/%s/commoninstancemetadata", projectID)
+		mutexKV.Lock(lockName)
+		defer mutexKV.Unlock(lockName)
+
 		log.Printf("[DEBUG] Loading project metadata: %s", projectID)
 		project, err := config.NewComputeClient(userAgent).Projects.Get(projectID).Do()
 		if err != nil {