add vpntunnel resourcerefs (#1123)

Merged PR #1123.
GoogleCloudPlatform · Jan 4, 2019 · b39dc08 · b39dc08
1 parent d589508
commit b39dc08
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 10 deletions.
diff --git a/build/ansible b/build/ansible
diff --git a/build/terraform b/build/terraform
diff --git a/build/terraform-beta b/build/terraform-beta
diff --git a/products/compute/api.yaml b/products/compute/api.yaml
@@ -2974,9 +2974,10 @@ objects:
         description: |
           Network IP address of an instance that should handle matching packets.
         input: true
-      # TODO(nelsonjr): Make this a ResourceRef when VpnTunnel is submitted.
-      - !ruby/object:Api::Type::String
+      - !ruby/object:Api::Type::ResourceRef
         name: 'nextHopVpnTunnel'
+        resource: 'VpnTunnel'
+        imports: 'selfLink'
         description: |
           URL to a VpnTunnel that should handle matching packets.
         input: true
@@ -4086,21 +4087,25 @@ objects:
       - !ruby/object:Api::Type::Array
         name: 'tunnels'
         description: |
-          A list of references to VpnTunnel resources associated to this VPN gateway.
-        # TODO(nelsonjr): Make this a ResourceRef when VpnTunnel is submitted.
-        item_type: Api::Type::String
+          A list of references to VpnTunnel resources associated with this VPN gateway.
+        item_type: !ruby/object:Api::Type::ResourceRef
+          name: 'tunnel'
+          resource: 'VpnTunnel'
+          imports: 'selfLink'
+          description: |
+            A VpnTunnel resource associated with this VPN gateway.
         output: true
       - !ruby/object:Api::Type::Array
         name: 'forwardingRules'
         description: |
-          A list of references to the ForwardingRule resources associated to this VPN
+          A list of references to the ForwardingRule resources associated with this VPN
           gateway.
         item_type: !ruby/object:Api::Type::ResourceRef
           name: 'forwardingRule'
           resource: 'ForwardingRule'
           imports: 'selfLink'
           description: |
-            A ForwardingRule resource associated to this VPN gateway.
+            A ForwardingRule resource associated with this VPN gateway.
         output: true
         # status is not useful for state convergence
   - !ruby/object:Api::Resource

diff --git a/third_party/terraform/tests/resource_compute_vpn_tunnel_test.go b/third_party/terraform/tests/resource_compute_vpn_tunnel_test.go
@@ -105,6 +105,7 @@ func testAccComputeVpnTunnel_basic() string {
 	return fmt.Sprintf(`
 resource "google_compute_network" "foobar" {
 	name = "tunnel-test-%s"
+	auto_create_subnetworks = false
 }
 resource "google_compute_subnetwork" "foobar" {
 	name = "tunnel-test-subnetwork-%s"
@@ -161,6 +162,7 @@ func testAccComputeVpnTunnel_regionFromGateway(region string) string {
 	return fmt.Sprintf(`
 resource "google_compute_network" "foobar" {
 	name = "tunnel-test-%s"
+	auto_create_subnetworks = false
 }
 resource "google_compute_subnetwork" "foobar" {
 	name = "tunnel-test-subnetwork-%s"
@@ -219,6 +221,7 @@ func testAccComputeVpnTunnelRouter(router string) string {
 	return fmt.Sprintf(`
 		resource "google_compute_network" "foobar" {
 			name = "tunnel-test-%s"
+			auto_create_subnetworks = false
 		}
 		resource "google_compute_subnetwork" "foobar" {
 			name = "tunnel-test-subnetwork-%s"
+14 −6		lib/ansible/modules/cloud/google/gcp_compute_route.py
+3 −2		lib/ansible/modules/cloud/google/gcp_compute_target_vpn_gateway.py
+3 −3		lib/ansible/modules/cloud/google/gcp_compute_target_vpn_gateway_facts.py