Instance sweeper (#3401)

* compute instance sweeper * test prefix in other tests * compile * use zone name
GoogleCloudPlatform · Apr 22, 2020 · b46a689 · b46a689
1 parent dff963f
commit b46a689
Show file tree

Hide file tree

Showing 7 changed files with 167 additions and 108 deletions.
diff --git a/third_party/terraform/tests/data_source_google_compute_instance_test.go b/third_party/terraform/tests/data_source_google_compute_instance_test.go
@@ -11,7 +11,7 @@ import (
 func TestAccDataSourceComputeInstance_basic(t *testing.T) {
 	t.Parallel()
 
-	instanceName := fmt.Sprintf("data-instance-test-%s", randString(t, 10))
+	instanceName := fmt.Sprintf("tf-test-%s", randString(t, 10))
 
 	vcrTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },

diff --git a/third_party/terraform/tests/resource_compute_instance_group_test.go b/third_party/terraform/tests/resource_compute_instance_group_test.go
@@ -15,7 +15,7 @@ func TestAccComputeInstanceGroup_basic(t *testing.T) {
 
 	var instanceGroup compute.InstanceGroup
 	var resourceName = "google_compute_instance_group.basic"
-	var instanceName = fmt.Sprintf("instancegroup-test-%s", randString(t, 10))
+	var instanceName = fmt.Sprintf("tf-test-%s", randString(t, 10))
 	var zone = "us-central1-c"
 
 	vcrTest(t, resource.TestCase{
@@ -50,10 +50,10 @@ func TestAccComputeInstanceGroup_basic(t *testing.T) {
 func TestAccComputeInstanceGroup_rename(t *testing.T) {
 	t.Parallel()
 
-	var instanceName = fmt.Sprintf("instancegroup-test-%s", randString(t, 10))
-	var instanceGroupName = fmt.Sprintf("instancegroup-test-%s", randString(t, 10))
-	var backendName = fmt.Sprintf("instancegroup-test-%s", randString(t, 10))
-	var healthName = fmt.Sprintf("instancegroup-test-%s", randString(t, 10))
+	var instanceName = fmt.Sprintf("tf-test-%s", randString(t, 10))
+	var instanceGroupName = fmt.Sprintf("tf-test-%s", randString(t, 10))
+	var backendName = fmt.Sprintf("tf-test-%s", randString(t, 10))
+	var healthName = fmt.Sprintf("tf-test-%s", randString(t, 10))
 
 	vcrTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
@@ -84,7 +84,7 @@ func TestAccComputeInstanceGroup_update(t *testing.T) {
 	t.Parallel()
 
 	var instanceGroup compute.InstanceGroup
-	var instanceName = fmt.Sprintf("instancegroup-test-%s", randString(t, 10))
+	var instanceName = fmt.Sprintf("tf-test-%s", randString(t, 10))
 
 	vcrTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
@@ -125,7 +125,7 @@ func TestAccComputeInstanceGroup_outOfOrderInstances(t *testing.T) {
 	t.Parallel()
 
 	var instanceGroup compute.InstanceGroup
-	var instanceName = fmt.Sprintf("instancegroup-test-%s", randString(t, 10))
+	var instanceName = fmt.Sprintf("tf-test-%s", randString(t, 10))
 
 	vcrTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
@@ -147,7 +147,7 @@ func TestAccComputeInstanceGroup_network(t *testing.T) {
 	t.Parallel()
 
 	var instanceGroup compute.InstanceGroup
-	var instanceName = fmt.Sprintf("instancegroup-test-%s", randString(t, 10))
+	var instanceName = fmt.Sprintf("tf-test-%s", randString(t, 10))
 
 	vcrTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },