Add missing return, fix nits

GoogleCloudPlatform · Mar 3, 2023 · b75f4ec · b75f4ec
1 parent 969bda0
commit b75f4ec
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/mmv1/third_party/terraform/tests/resource_composer_environment_test.go.erb b/mmv1/third_party/terraform/tests/resource_composer_environment_test.go.erb
@@ -971,7 +971,8 @@ func grantEncrypterDecrypterRoleToServiceAgents(t *testing.T) {
 		"gcp-sa-artifactregistry",
 		"gcp-sa-pubsub",
 	}
-	if policyChanged := BootstrapAllPSARole(t, serviceAgents, "roles/cloudkms.cryptoKeyEncrypterDecrypter"); policyChanged {
+	role := "roles/cloudkms.cryptoKeyEncrypterDecrypter"
+	if policyChanged := BootstrapAllPSARole(t, serviceAgents, role); policyChanged {
 		// Fail this test run because the policy needs time to reconcile.
 		t.Fatalf("Granted crypto key encrypter/decrypter role for service agents %v in test project's IAM policy. Retry the test in a few minutes.", serviceAgents)
 	}

diff --git a/mmv1/third_party/terraform/utils/iam.go.erb b/mmv1/third_party/terraform/utils/iam.go.erb
@@ -484,6 +484,8 @@ func missingBindingsMap(aMap, bMap map[iamBindingKey]map[string]struct{}) map[ia
 			results[key] = bMembers
 		}
 	}
+
+	return results
 }
 
 // Returns the bindings that are in one set of bindings and not the other.
-Original file line number
+Diff line change
@@ Expand Up @@
     			results[key] = bMembers
     		}
     	}
+    	return results
     }
     // Returns the bindings that are in one set of bindings and not the other.
@@ Expand Down @@