[Terraform]: Remove update_strategy from rigm. (#1002)

Merged PR #1002.
GoogleCloudPlatform · Dec 10, 2018 · c388879 · c388879
1 parent 62e235b
commit c388879
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 10 deletions.
diff --git a/build/inspec b/build/inspec
diff --git a/build/terraform b/build/terraform
diff --git a/build/terraform-beta b/build/terraform-beta
diff --git a/third_party/terraform/resources/resource_compute_region_instance_group_manager.go.erb b/third_party/terraform/resources/resource_compute_region_instance_group_manager.go.erb
@@ -172,10 +172,9 @@ func resourceComputeRegionInstanceGroupManager() *schema.Resource {
 <% if version.nil? || version == 'ga' -%>
 			"update_strategy": &schema.Schema{
 				Type:         schema.TypeString,
-				Deprecated:   "This field is deprecated as it has no functionality anymore. It will be removed in 3.0.0.",
+				Deprecated:   "This field is removed.",
 				Optional:     true,
 				Computed:     true,
-				ValidateFunc: validation.StringInSlice([]string{"NONE", "ROLLING_UPDATE"}, false),
 			},
 <% end -%>
 

diff --git a/third_party/terraform/tests/resource_compute_region_instance_group_manager_test.go.erb b/third_party/terraform/tests/resource_compute_region_instance_group_manager_test.go.erb
@@ -148,7 +148,6 @@ func TestAccRegionInstanceGroupManager_updateStrategy(t *testing.T) {
 				ResourceName:            "google_compute_region_instance_group_manager.igm-update-strategy",
 				ImportState:             true,
 				ImportStateVerify:       true,
-				ImportStateVerifyIgnore: []string{"update_strategy"},
 			},
 		},
 	})
@@ -998,7 +997,6 @@ resource "google_compute_region_instance_group_manager" "igm-update-strategy" {
 	base_instance_name         = "rigm-update-strategy"
 	region                     = "us-central1"
 	target_size                = 2
-	update_strategy            = "NONE"
 	named_port {
 		name = "customhttp"
 		port = 8080

diff --git a/...ty/terraform/website/docs/r/compute_region_instance_group_manager.html.markdown b/...ty/terraform/website/docs/r/compute_region_instance_group_manager.html.markdown
@@ -116,9 +116,6 @@ The following arguments are supported:
 * `project` - (Optional) The ID of the project in which the resource belongs. If it
     is not provided, the provider project is used.
 
-* `update_strategy` - (Optional, Default `"NONE"`) This field is deprecated as it has no functionality anymore.
-It previously turned update behaviour on and off. This field is only present in the `google` provider.
-
 * `target_size` - (Optional) The target number of running instances for this managed
     instance group. This value should always be explicitly set unless this resource is attached to
      an autoscaler, in which case it should never be set. Defaults to `0`.