[Terraform]: Mark the deleted field computed in google_project_iam_custom_role #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
|
I think this might make things more complicated with getting everything in order after 1.20.0 if we do it now (and will probably cause that PR to have merge conflicts)- mind waiting until that's done to merge this? |
|
Sounds good - I'll re-request review when |
rileykarson
requested review from
danawillow
and removed request for
danawillow
danawillow
approved these changes
Dec 14, 2018
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
remove-project-custom-role-deleted
branch
from
92569c0 to
b37c311
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of hashicorp/terraform-provider-google#1203, Parallel to #1004
The commit that deprecates the field (hashicorp/terraform-provider-google-beta@2ded101) won't hit
2.0.0afaik, so this will look like we're doing this with no deprecation. It will have landed in1.20.0. Time traveling code is fun![all]
[terraform]
Mark the deleted field computed in google_project_iam_custom_role
[terraform-beta]
[ansible]
[inspec]