Add support for AuthorizedView resource in Bigtable

[trollyxia]

Release Note Template for Downstream PRs (will be copied)

`google_bigtable_authorized_view`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1321 insertions(+))
google-beta provider: Diff ( 4 files changed, 1321 insertions(+))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• bigtable

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1302 insertions(+))
google-beta provider: Diff ( 4 files changed, 1302 insertions(+))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• bigtable

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log

[c2thorn]

Apologies, I thought I left a comment but it must not have sent.
The build is failing with bigtable.AuthorizedViewConf being undefined.

I believe we will have to update the cloud.google.com/go/bigtable dependency

yaqs/8444818848342867968 should have a note that explains how to do that in our go.mod

[trollyxia]

Sorry it took a while for us to merge the cloud.google.com/go/bigtable dependency for this PR. Now the dependency is finally merged, and the go.mod is updated accordingly.

@c2thorn Can you please start review this PR? Thanks!

[c2thorn]

We should update the go.sum as gets generated as well. You should just be able to copy and paste the result after running go get cloud.google.com/go/bigtable in the provider

[trollyxia]

Thanks for the info! Done.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1303 insertions(+))
google-beta provider: Diff ( 4 files changed, 1303 insertions(+))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• bigtable

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1265 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 1265 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigtable_authorized_view (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_authorized_view" "primary" {
  project = # value needed
}

[c2thorn]

Why do we have validation for subset_view here, but have it set as optional in the field schema?

[trollyxia]

Since the subset_view is actually one variant in a one-of field in the AuthorizedView API proto as below:

  // The type of this AuthorizedView.
  oneof authorized_view {
    // An AuthorizedView permitting access to an explicit subset of a Table.
    SubsetView subset_view = 2;
  }

Although it is currently the only possible variant in that one-of field, in the future we might add other types of authorized views. Therefore each one-of variant will be optional in the field schema.

However we also want to make sure that at least one of the possible variants are set, hence the validation here. In the future when we have other variants, we will adjust the validation accordingly.

[c2thorn]

That makes sense. Refreshing to see considerations for future changes, thank you!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1406 insertions(+), 101 deletions(-))
google-beta provider: Diff ( 6 files changed, 1406 insertions(+), 101 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigtable_authorized_view (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_authorized_view" "primary" {
  project = # value needed
}

[modular-magician]

Tests analytics

Total tests: 3633
Passed tests: 3263
Skipped tests: 369
Affected tests: 1

Click here to see the affected service packages

all service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccHealthcareDatasetIamPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccHealthcareDatasetIamPolicy[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1568 insertions(+), 101 deletions(-))
google-beta provider: Diff ( 7 files changed, 1568 insertions(+), 101 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigtable_authorized_view (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_authorized_view" "primary" {
  project = # value needed
}

[modular-magician]

Tests analytics

Total tests: 3633
Passed tests: 3264
Skipped tests: 369
Affected tests: 0

Click here to see the affected service packages

all service packages are affected

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

[c2thorn]

Don't see any other changes necessary, so I'm going to go ahead and commit my small suggestion to move things along.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1570 insertions(+), 101 deletions(-))
google-beta provider: Diff ( 7 files changed, 1570 insertions(+), 101 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigtable_authorized_view (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_authorized_view" "primary" {
  project = # value needed
}

[modular-magician]

Tests analytics

Total tests: 3633
Passed tests: 3264
Skipped tests: 369
Affected tests: 0

Click here to see the affected service packages

all service packages are affected

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

[c2thorn]

Looks like another PR was merged that modified the go.mod.erb file. May have to rerun the dependency upgrade with go get <dependency>

[trollyxia]

Looks like another PR was merged that modified the go.mod.erb file. May have to rerun the dependency upgrade with go get <dependency>

Done.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1483 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 7 files changed, 1483 insertions(+), 16 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigtable_authorized_view (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_authorized_view" "primary" {
  project = # value needed
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1483 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 7 files changed, 1483 insertions(+), 16 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigtable_authorized_view (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_authorized_view" "primary" {
  project = # value needed
}

[modular-magician]

Tests analytics

Total tests: 3633
Passed tests: 3264
Skipped tests: 369
Affected tests: 0

Click here to see the affected service packages

all service packages are affected

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

[modular-magician]

Tests analytics

Total tests: 3633
Passed tests: 3264
Skipped tests: 369
Affected tests: 0

Click here to see the affected service packages

all service packages are affected

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

[c2thorn]

LGTM