add nfs support to cloudrun v2 jobs in beta

[bskaplan]

fixes hashicorp/terraform-provider-google#17336

Support new feature NFS in cloudrunv2 jobs in beta.

This finishes Beta support for hashicorp/terraform-provider-google#17336

Release Note Template for Downstream PRs (will be copied)

cloudrunv2: added `template.volumes.nfs` field to `google_cloud_run_v2_job` resource (beta)

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[roaks3]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 19 insertions(+))
google-beta provider: Diff ( 3 files changed, 190 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 52 insertions(+))

[modular-magician]

Tests analytics

Total tests: 40
Passed tests: 39
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• cloudrunv2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudRunV2Job_cloudrunv2JobWithNfsUpdate

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudRunV2Job_cloudrunv2JobWithNfsUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[yanweiguo]

LGTM

[roaks3]

I'll wait for you to respond on my last message before merging.

[roaks3]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 19 insertions(+))
google-beta provider: Diff ( 3 files changed, 190 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 52 insertions(+))

[roaks3]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 19 insertions(+))
google-beta provider: Diff ( 3 files changed, 190 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 52 insertions(+))

[roaks3]

FYI this should be ready to merge, but we're having difficulty with the PR checks. I'm working with the team to resolve, but will hold on merging this in the meantime.

[melinath]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 19 insertions(+))
google-beta provider: Diff ( 3 files changed, 190 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 52 insertions(+))

[modular-magician]

Tests analytics

Total tests: 40
Passed tests: 40
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• cloudrunv2

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

[roaks3]

@bskaplan just to double check, I think this resolves hashicorp/terraform-provider-google#17336. Could you confirm?

[bskaplan]

It resolves it in the beta provider. Is standard practice here to resolve the issue when it makes it to beta or wait until it goes to GA?

[roaks3]

Ok cool, we would normally consider it closed as soon as it is resolved in beta. I'll update the description to auto-close the issue