Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove beta label from GKE autoscaling_profile #10302

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

pradithya
Copy link
Contributor

Update documentation to reflect #9558

GKE autoscaling profile has been in the google provider for a while but the documentation still only shows google-beta

Release Note Template for Downstream PRs (will be copied)


@github-actions github-actions bot requested a review from c2thorn March 27, 2024 08:00
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@c2thorn c2thorn self-requested a review March 27, 2024 20:22
@c2thorn
Copy link
Member

c2thorn commented Mar 27, 2024

/gcbrun

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests service/container and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Mar 27, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@c2thorn c2thorn merged commit ae8c6b7 into GoogleCloudPlatform:main Mar 27, 2024
12 checks passed
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Mar 27, 2024
…0302)

Co-authored-by: Pradithya Aria <pradithya.pura@go-jek.com>
pjotrekk pushed a commit to pjotrekk/magic-modules that referenced this pull request Apr 2, 2024
…0302)

Co-authored-by: Pradithya Aria <pradithya.pura@go-jek.com>
cmfeng pushed a commit to cmfeng/cmfeng-magic-modules that referenced this pull request Apr 5, 2024
…0302)

Co-authored-by: Pradithya Aria <pradithya.pura@go-jek.com>
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Apr 9, 2024
…0302)

Co-authored-by: Pradithya Aria <pradithya.pura@go-jek.com>
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
…0302)

Co-authored-by: Pradithya Aria <pradithya.pura@go-jek.com>
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
…0302)

Co-authored-by: Pradithya Aria <pradithya.pura@go-jek.com>
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
…0302)

Co-authored-by: Pradithya Aria <pradithya.pura@go-jek.com>
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
…0302)

Co-authored-by: Pradithya Aria <pradithya.pura@go-jek.com>
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
…0302)

Co-authored-by: Pradithya Aria <pradithya.pura@go-jek.com>
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
…0302)

Co-authored-by: Pradithya Aria <pradithya.pura@go-jek.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants