Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased google_compute_security_policy timeouts to 20 minutes (default) #10385

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

melinath
Copy link
Member

@melinath melinath commented Apr 5, 2024

Fixed hashicorp/terraform-provider-google#16743

Release Note Template for Downstream PRs (will be copied)

compute: increased `google_compute_security_policy` timeouts from 8 minutes to 20 minutes

@melinath melinath requested review from a team and shuyama1 and removed request for a team April 5, 2024 22:31
@melinath melinath changed the title Increased timeout to 20 minutes (default) Increased google_compute_security_policy timeouts to 20 minutes (default) Apr 5, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))

@modular-magician

This comment was marked as outdated.

@melinath
Copy link
Member Author

melinath commented Apr 5, 2024

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))

@melinath
Copy link
Member Author

melinath commented Apr 6, 2024

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 892
Passed tests: 820
Skipped tests: 72
Affected tests: 0

Click here to see the affected service packages
  • compute

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@melinath melinath merged commit 269a04f into GoogleCloudPlatform:main Apr 8, 2024
14 checks passed
@melinath melinath deleted the tpg-16743 branch April 8, 2024 18:33
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccComputeBackend* with Security Policy
3 participants