-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add labels validations #10387
feat: add labels validations #10387
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
@zli82016 do you mind taking this review? Would this conflict with the customizediff at all? |
I will take this review. |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
I run tests locally. |
Tests analyticsTotal tests: Click here to see the affected service packages
|
@EladLeev , can you please fix the build error? Thanks.
|
add missing import
That's embarrassing 🤦 haha, sorry for that. |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
|
@EladLeev , is there a Github issue or buganizer issue for this PR? If yes, can you please add it to the description section of this PR with the format |
Not really tbh. I can search the open issues to see if someone mentioned it, but it's something I'm facing from time to time (with many providers) and might give a better DevEx to users |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM.
Hey 👋
A quick PR to add some labels validations based on the documentation.
The problem this PR is trying to solve is that nothing validates that the labels are correct before the apply phase which gets an error from the API.
Release Note Template for Downstream PRs (will be copied)