Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for intercept_children in sinks #10402

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

Jbodeau
Copy link
Contributor

@Jbodeau Jbodeau commented Apr 9, 2024

Add support for recently created intercept_children property on log sinks, used for intercepting aggregated sinks. Docs for feature: https://cloud.google.com/logging/docs/export/aggregated_sinks

Release Note Template for Downstream PRs (will be copied)

logging: added `intercept_children` field to `google_logging_organization_sink` and `google_logging_folder_sink` resources

@github-actions github-actions bot requested a review from NickElliot April 9, 2024 21:09
Copy link

github-actions bot commented Apr 9, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, one question for clarification

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 143 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 5 files changed, 143 insertions(+), 10 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 68
Passed tests: 61
Skipped tests: 0
Affected tests: 7

Click here to see the affected service packages
  • logging

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccLoggingFolderSink_removeOptionals|TestAccLoggingFolderSink_update|TestAccLoggingFolderSink_updateBigquerySink|TestAccLoggingFolderSink_updateInterceptChildren|TestAccLoggingOrganizationSink_update|TestAccLoggingOrganizationSink_updateBigquerySink|TestAccLoggingOrganizationSink_updateInterceptChildren

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccLoggingFolderSink_removeOptionals[Debug log]
TestAccLoggingFolderSink_update[Debug log]
TestAccLoggingFolderSink_updateBigquerySink[Debug log]
TestAccLoggingFolderSink_updateInterceptChildren[Debug log]
TestAccLoggingOrganizationSink_update[Debug log]
TestAccLoggingOrganizationSink_updateBigquerySink[Debug log]
TestAccLoggingOrganizationSink_updateInterceptChildren[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NickElliot NickElliot merged commit 5015ca8 into GoogleCloudPlatform:main Apr 22, 2024
10 checks passed
@Jbodeau Jbodeau deleted the intercepting-sink branch April 23, 2024 13:23
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants