-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for intercept_children in sinks #10402
Add support for intercept_children in sinks #10402
Conversation
…n the API and it won't change.
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, one question for clarification
mmv1/third_party/terraform/services/logging/resource_logging_folder_sink.go
Outdated
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccLoggingFolderSink_removeOptionals|TestAccLoggingFolderSink_update|TestAccLoggingFolderSink_updateBigquerySink|TestAccLoggingFolderSink_updateInterceptChildren|TestAccLoggingOrganizationSink_update|TestAccLoggingOrganizationSink_updateBigquerySink|TestAccLoggingOrganizationSink_updateInterceptChildren |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Add support for recently created
intercept_children
property on log sinks, used for intercepting aggregated sinks. Docs for feature: https://cloud.google.com/logging/docs/export/aggregated_sinksRelease Note Template for Downstream PRs (will be copied)