Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuring forward proxy in Apigee Environment. #10457

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

xuchenma
Copy link
Contributor

@xuchenma xuchenma commented Apr 16, 2024

Add support for configuring forward proxy in Apigee Environment.

Release Note Template for Downstream PRs (will be copied)

apigee: added `forward_proxy_uri` field to `google_apigee_environment`

@github-actions github-actions bot requested a review from slevenick April 16, 2024 03:40
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 36 insertions(+))
google-beta provider: Diff ( 4 files changed, 45 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@xuchenma
Copy link
Contributor Author

Local test run pass:

--- PASS: TestAccApigeeEnvironment_apigeeEnvironmentPatchUpdateTestExampleUpdate (1082.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-google-beta/google-beta/services/apigee	1082.672s

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 36
Passed tests: 10
Skipped tests: 26
Affected tests: 0

Click here to see the affected service packages
  • apigee

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the changelog note to match our expected format? https://googlecloudplatform.github.io/magic-modules/contribute/release-notes/

@slevenick slevenick self-requested a review April 16, 2024 13:27
Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need changelog note update, otherwise looks good. Tests ran in CI

@xuchenma
Copy link
Contributor Author

Thanks for the review; updated the release note to remove the trailing line.

@slevenick
Copy link
Contributor

I meant the content of the note needs an update. See our example on that page:

compute: added `foo_bar` field to `google_compute_foo` resource

I'll update it for now, but in the future please use the standard format

@slevenick slevenick merged commit 43c57ad into GoogleCloudPlatform:main Apr 18, 2024
15 of 17 checks passed
@xuchenma xuchenma deleted the 0412 branch April 18, 2024 16:48
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants