-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote external_dataset_reference
in bigquery_dataset
to GA
#10516
Promote external_dataset_reference
in bigquery_dataset
to GA
#10516
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigQueryDataset_bigqueryDatasetExternalReferenceAwsTestExample |
|
As part of review I'm running the TestAccBigQueryDataset_bigqueryDatasetExternalReferenceAwsTestExample test against the GA provider in TeamCity, as the test passing above is using the Beta provider and isn't a reliable test of the PR's changes. This won't be accessible to you, posting here as a note for later! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test that contains the promoted field passes when run with the GA provider - approved 🚢
external_dataset_reference
inbigquery_dataset
to GAbigquery_dataset_external_reference_aws_docs
tobigquery_dataset_external_reference_aws
(the name is used in the public documentation)bigquery_dataset_external_reference_aws
tobigquery_dataset_external_reference_aws_test
Fixes hashicorp/terraform-provider-google#17942
Release Note Template for Downstream PRs (will be copied)