Promote external_dataset_reference in bigquery_dataset to GA

[obada-ab]

• Promote external_dataset_reference in bigquery_dataset to GA
• Rename the docs example bigquery_dataset_external_reference_aws_docs to bigquery_dataset_external_reference_aws (the name is used in the public documentation)
• Rename the test example bigquery_dataset_external_reference_aws to bigquery_dataset_external_reference_aws_test

Fixes hashicorp/terraform-provider-google#17942

Release Note Template for Downstream PRs (will be copied)

bigquery: promoted `external_dataset_reference` in `bigquery_dataset` to GA

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 139 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 6 insertions(+), 8 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 112 insertions(+))

[modular-magician]

Tests analytics

Total tests: 115
Passed tests: 103
Skipped tests: 11
Affected tests: 1

Click here to see the affected service packages

• bigquery

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigQueryDataset_bigqueryDatasetExternalReferenceAwsTestExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryDataset_bigqueryDatasetExternalReferenceAwsTestExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[SarahFrench]

As part of review I'm running the TestAccBigQueryDataset_bigqueryDatasetExternalReferenceAwsTestExample test against the GA provider in TeamCity, as the test passing above is using the Beta provider and isn't a reliable test of the PR's changes. This won't be accessible to you, posting here as a note for later!

[SarahFrench]

The test that contains the promoted field passes when run with the GA provider - approved 🚢