-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade DCL to 1.65.0 #10531
Upgrade DCL to 1.65.0 #10531
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_clouddeploy_target" "primary" {
custom_target {
custom_target_type = # value needed
}
}
Resource: resource "google_compute_firewall_policy_rule" "primary" {
security_profile_group = # value needed
tls_inspect = # value needed
}
Resource: resource "google_compute_network_firewall_policy_rule" "primary" {
security_profile_group = # value needed
tls_inspect = # value needed
}
Resource: resource "google_compute_region_network_firewall_policy_rule" "primary" {
security_profile_group = # value needed
tls_inspect = # value needed
}
Resource: resource "google_privateca_certificate_template" "primary" {
maximum_lifetime = # value needed
}
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_firewall_policy_rule" "primary" {
security_profile_group = # value needed
tls_inspect = # value needed
}
Resource: resource "google_compute_network_firewall_policy_rule" "primary" {
security_profile_group = # value needed
tls_inspect = # value needed
}
Resource: resource "google_compute_region_network_firewall_policy_rule" "primary" {
security_profile_group = # value needed
tls_inspect = # value needed
}
Resource: resource "google_privateca_certificate_template" "primary" {
maximum_lifetime = # value needed
}
|
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeFirewallPolicyRule_BasicFirSecRuleHandWritten|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeFirewallPolicyRule_update|TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten|TestAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten|TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update |
|
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccClouddeployTarget_CustomTarget|TestAccComputeFirewallPolicyRule_BasicFirSecRuleHandWritten|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeFirewallPolicyRule_update|TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten|TestAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten|TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_firewall_policy_rule" "primary" {
security_profile_group = # value needed
tls_inspect = # value needed
}
Resource: resource "google_compute_network_firewall_policy_rule" "primary" {
security_profile_group = # value needed
tls_inspect = # value needed
}
Resource: resource "google_compute_region_network_firewall_policy_rule" "primary" {
security_profile_group = # value needed
tls_inspect = # value needed
}
|
|
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccClouddeployTarget_CustomTarget|TestAccComputeFirewallPolicyRule_BasicFirSecRuleHandWritten|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeFirewallPolicyRule_update|TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten|TestAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate|TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update |
|
Release Note Template for Downstream PRs (will be copied)