Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade DCL to 1.65.0 #10531

Closed
wants to merge 3 commits into from
Closed

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Apr 25, 2024

Release Note Template for Downstream PRs (will be copied)

clouddeploy: added `custom_target` field to  `google_clouddeploy_target` resource
privateca: added `maximum_lifetime` field to  `google_privateca_certificate_template` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 236 insertions(+), 45 deletions(-))
google-beta provider: Diff ( 16 files changed, 236 insertions(+), 45 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_clouddeploy_target (15 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_clouddeploy_target" "primary" {
  custom_target {
    custom_target_type = # value needed
  }
}

Resource: google_compute_firewall_policy_rule (9 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_firewall_policy_rule" "primary" {
  security_profile_group = # value needed
  tls_inspect            = # value needed
}

Resource: google_compute_network_firewall_policy_rule (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_network_firewall_policy_rule" "primary" {
  security_profile_group = # value needed
  tls_inspect            = # value needed
}

Resource: google_compute_region_network_firewall_policy_rule (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_network_firewall_policy_rule" "primary" {
  security_profile_group = # value needed
  tls_inspect            = # value needed
}

Resource: google_privateca_certificate_template (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_privateca_certificate_template" "primary" {
  maximum_lifetime = # value needed
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 17 files changed, 366 insertions(+), 45 deletions(-))
google-beta provider: Diff ( 17 files changed, 366 insertions(+), 45 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_firewall_policy_rule (9 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_firewall_policy_rule" "primary" {
  security_profile_group = # value needed
  tls_inspect            = # value needed
}

Resource: google_compute_network_firewall_policy_rule (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_network_firewall_policy_rule" "primary" {
  security_profile_group = # value needed
  tls_inspect            = # value needed
}

Resource: google_compute_region_network_firewall_policy_rule (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_network_firewall_policy_rule" "primary" {
  security_profile_group = # value needed
  tls_inspect            = # value needed
}

Resource: google_privateca_certificate_template (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_privateca_certificate_template" "primary" {
  maximum_lifetime = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3626
Passed tests: 3254
Skipped tests: 366
Affected tests: 6

Click here to see the affected service packages
all service packages are affected

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeFirewallPolicyRule_BasicFirSecRuleHandWritten|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeFirewallPolicyRule_update|TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten|TestAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten|TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_BasicFirSecRuleHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_update[Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten[Error message] [Debug log]
TestAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten[Error message] [Debug log]
TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3627
Passed tests: 3254
Skipped tests: 366
Affected tests: 7

Click here to see the affected service packages
all service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccClouddeployTarget_CustomTarget|TestAccComputeFirewallPolicyRule_BasicFirSecRuleHandWritten|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeFirewallPolicyRule_update|TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten|TestAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten|TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 17 files changed, 372 insertions(+), 45 deletions(-))
google-beta provider: Diff ( 17 files changed, 372 insertions(+), 45 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_firewall_policy_rule (9 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_firewall_policy_rule" "primary" {
  security_profile_group = # value needed
  tls_inspect            = # value needed
}

Resource: google_compute_network_firewall_policy_rule (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_network_firewall_policy_rule" "primary" {
  security_profile_group = # value needed
  tls_inspect            = # value needed
}

Resource: google_compute_region_network_firewall_policy_rule (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_network_firewall_policy_rule" "primary" {
  security_profile_group = # value needed
  tls_inspect            = # value needed
}

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccClouddeployTarget_CustomTarget[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_BasicFirSecRuleHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_update[Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten[Error message] [Debug log]
TestAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten[Error message] [Debug log]
TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3629
Passed tests: 3255
Skipped tests: 366
Affected tests: 8

Click here to see the affected service packages
all service packages are affected

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccClouddeployTarget_CustomTarget|TestAccComputeFirewallPolicyRule_BasicFirSecRuleHandWritten|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeFirewallPolicyRule_update|TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten|TestAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate|TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccClouddeployTarget_CustomTarget[Debug log]
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_BasicFirSecRuleHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_update[Error message] [Debug log]
TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten[Error message] [Debug log]
TestAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten[Error message] [Debug log]
TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants