-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KMS support for the google_bigquery_connection resource #10561
Conversation
Add data resource for project
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
mmv1/templates/terraform/examples/bigquery_connection_kms.tf.erb
Outdated
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample |
Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.
|
Hi! I'm taking over this review from Scott. |
mmv1/templates/terraform/examples/bigquery_connection_kms.tf.erb
Outdated
Show resolved
Hide resolved
mmv1/templates/terraform/examples/bigquery_connection_kms.tf.erb
Outdated
Show resolved
Hide resolved
mmv1/templates/terraform/examples/bigquery_connection_kms.tf.erb
Outdated
Show resolved
Hide resolved
Hi! Thanks for the review, i will see too it. |
bootstrap KMS assign role via policyChanged override for service agent
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the tests passed successfully! 🎉 Just a few small cleanups and it should be good to go.
mmv1/templates/terraform/examples/bigquery_connection_kms.tf.erb
Outdated
Show resolved
Hide resolved
database_instance_name: 'my-database-instance' | ||
username: 'user' | ||
deletion_protection: 'true' | ||
kms_key_name: 'bq-key' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a full name since it's not a reference - projects/[kms_project_id]/locations/[region]/keyRings/[key_region]/cryptoKeys/[key]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked at the other example. Hope this works...
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…oudPlatform#10561) Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
…oudPlatform#10561) Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
…oudPlatform#10561) Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
…oudPlatform#10561) Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
…oudPlatform#10561) Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Fixes: hashicorp/terraform-provider-google#17955
Release Note Template for Downstream PRs (will be copied)