Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump metastore federation to ga #10569

Merged
merged 2 commits into from
May 10, 2024

Conversation

DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 commented May 1, 2024

Release Note Template for Downstream PRs (will be copied)

dataprocmetastore: promoted `google_dataproc_metastore_federation` to GA

@github-actions github-actions bot requested a review from zli82016 May 1, 2024 00:20
Copy link

github-actions bot commented May 1, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests service/metastore and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels May 1, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1015 insertions(+), 18 deletions(-))
google-beta provider: Diff ( 3 files changed, 15 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 3 insertions(+))

@DrFaust92 DrFaust92 requested a review from zli82016 May 10, 2024 10:17
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels May 10, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1016 insertions(+), 21 deletions(-))
google-beta provider: Diff ( 3 files changed, 1 insertion(+), 18 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 3 insertions(+))

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@zli82016 zli82016 merged commit 7b6d394 into GoogleCloudPlatform:main May 10, 2024
13 checks passed
kautikdk pushed a commit to kautikdk/magic-modules that referenced this pull request May 16, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants