Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ncc rep resource #10573

Merged
merged 22 commits into from
May 2, 2024
Merged

Conversation

simalcubuk
Copy link
Contributor

@simalcubuk simalcubuk commented May 1, 2024

Add a new resource google_network_connectivity_regional_endpoint in v1 API version under product networkconnectivity.
Discovery doc: https://networkconnectivity.googleapis.com/$discovery/rest?version=v1

`google_network_connectivity_regional_endpoint`

@github-actions github-actions bot requested a review from zli82016 May 1, 2024 13:52
Copy link

github-actions bot commented May 1, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels May 1, 2024
@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 1, 2024
@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 1, 2024
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels May 1, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1068 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1068 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 136 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 258 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_connectivity_regional_endpoint (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_regional_endpoint" "primary" {
  description = # value needed
  labels      = # value needed
  project     = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 13
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • networkconnectivity

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkConnectivityRegionalEndpoint_networkConnectivityRegionalEndpointGlobalAccessExample|TestAccNetworkConnectivityRegionalEndpoint_networkConnectivityRegionalEndpointRegionalAccessExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetworkConnectivityRegionalEndpoint_networkConnectivityRegionalEndpointGlobalAccessExample[Error message] [Debug log]
TestAccNetworkConnectivityRegionalEndpoint_networkConnectivityRegionalEndpointRegionalAccessExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels May 1, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1068 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1068 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 136 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 258 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_connectivity_regional_endpoint (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_regional_endpoint" "primary" {
  description = # value needed
  labels      = # value needed
  project     = # value needed
}

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 1, 2024
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 13
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • networkconnectivity

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkConnectivityRegionalEndpoint_networkConnectivityRegionalEndpointGlobalAccessExample|TestAccNetworkConnectivityRegionalEndpoint_networkConnectivityRegionalEndpointRegionalAccessExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetworkConnectivityRegionalEndpoint_networkConnectivityRegionalEndpointGlobalAccessExample[Error message] [Debug log]
TestAccNetworkConnectivityRegionalEndpoint_networkConnectivityRegionalEndpointRegionalAccessExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 1, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1070 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1070 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 136 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 259 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 13
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • networkconnectivity

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkConnectivityRegionalEndpoint_networkConnectivityRegionalEndpointGlobalAccessExample|TestAccNetworkConnectivityRegionalEndpoint_networkConnectivityRegionalEndpointRegionalAccessExample

Get to know how VCR tests work

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 2, 2024
@github-actions github-actions bot requested a review from zli82016 May 2, 2024 19:07
@github-actions github-actions bot requested a review from zli82016 May 2, 2024 19:10
@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 2, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1062 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1062 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 136 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 246 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_connectivity_regional_endpoint (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_regional_endpoint" "primary" {
  project = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 15
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • networkconnectivity

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@github-actions github-actions bot requested a review from zli82016 May 2, 2024 19:59
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels May 2, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1062 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 1062 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 136 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 246 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_connectivity_regional_endpoint (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_regional_endpoint" "primary" {
  project = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 15
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • networkconnectivity

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016 zli82016 merged commit 07c06ec into GoogleCloudPlatform:main May 2, 2024
14 checks passed
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
Co-authored-by: Simal Cubuk <rsimalcubuk@google.com>
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
Co-authored-by: Simal Cubuk <rsimalcubuk@google.com>
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Co-authored-by: Simal Cubuk <rsimalcubuk@google.com>
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
Co-authored-by: Simal Cubuk <rsimalcubuk@google.com>
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Co-authored-by: Simal Cubuk <rsimalcubuk@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants