Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExtraAttributesOauthClient field for google_iam_workforce_pool_provider resource #10592

Merged

Conversation

omkark-google
Copy link
Contributor

@omkark-google omkark-google commented May 3, 2024

Add support for extra attributes oauth2 client fields to create workforce pool operation. This address the gap between newly added support in Gcloud command of iam create workforce pool provider and iam update workforce pool provider.

Fixes hashicorp/terraform-provider-google#18021

iam: added `extra_attributes_oauth2_client` field to `google_iam_workforce_pool_provider` resource

fields to create workforce pool operation. This
address the gap between newly added support in
Gcloud command of iam create workforce pool
provider and iam update workforce pool provider.
Copy link

github-actions bot commented May 3, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from zli82016 May 3, 2024 17:43
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests service/iam-workforce and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels May 3, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 899 insertions(+), 19 deletions(-))
google-beta provider: Diff ( 4 files changed, 899 insertions(+), 19 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 141 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 14
Passed tests: 11
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • iamworkforcepool

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccIAMWorkforcePoolWorkforcePoolProvider_extraAttributesOauth2Client|TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderExtraAttributesOauth2ConfigClientBasicExample|TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderExtraAttributesOauth2ConfigClientFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccIAMWorkforcePoolWorkforcePoolProvider_extraAttributesOauth2Client[Debug log]
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderExtraAttributesOauth2ConfigClientBasicExample[Debug log]
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderExtraAttributesOauth2ConfigClientFullExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

fields to create workforce pool operation. This
address the gap between newly added support in
Gcloud command of iam create workforce pool
provider and iam update workforce pool provider.
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels May 3, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 899 insertions(+), 19 deletions(-))
google-beta provider: Diff ( 4 files changed, 899 insertions(+), 19 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 141 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 14
Passed tests: 14
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • iamworkforcepool

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@omkark-google
Copy link
Contributor Author

Hi @zli82016, can you please take a look at PR. Thanks

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice changes.

@zli82016 zli82016 merged commit e66c6af into GoogleCloudPlatform:main May 6, 2024
15 checks passed
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ExtraAttributesOauthClient field for google_iam_workforce_pool_provider resource
3 participants