Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing version guards for fields going GA #10613

Merged

Conversation

Gorlami96
Copy link
Contributor

@Gorlami96 Gorlami96 commented May 7, 2024

Related to b/309454013. Promoting beta fields to GA.

Release Note Template for Downstream PRs (will be copied)

compute: promoted `identifier_range` field in `google_compute_router` resource to GA
compute: promoted `ip_version` field in `google_compute_router_interface` resource to GA
compute: promoted `enable_ipv4`, `ipv4_nexthop_address` and `peer_ipv4_nexthop_address` fields in `google_compute_router_peer` resource to GA

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 528 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 6 files changed, 5 insertions(+), 33 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 906
Passed tests: 830
Skipped tests: 72
Affected tests: 4

Click here to see the affected service packages
  • compute

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRouterInterface_withIPVersionV4|TestAccComputeRouterInterface_withIPVersionV6|TestAccComputeRouterPeer_Ipv4BasicCreateUpdate|TestAccComputeRouter_addAndUpdateIdentifierRangeBgp

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeRouterInterface_withIPVersionV4[Error message] [Debug log]
TestAccComputeRouterInterface_withIPVersionV6[Error message] [Debug log]
TestAccComputeRouterPeer_Ipv4BasicCreateUpdate[Error message] [Debug log]
TestAccComputeRouter_addAndUpdateIdentifierRangeBgp[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 528 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 6 files changed, 9 insertions(+), 37 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 906
Passed tests: 834
Skipped tests: 72
Affected tests: 0

Click here to see the affected service packages
  • compute

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@Gorlami96 Gorlami96 marked this pull request as ready for review May 8, 2024 04:36
Copy link

github-actions bot commented May 8, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from SarahFrench May 8, 2024 04:37
Copy link
Collaborator

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your PR!

I'm going to run tests against this PR using the GA provider (automated testing on PRs uses the Beta provider only) but assuming those tests all pass I'm happy to approve and merge.

Edit: links to tests for my reference in future - not everyone can access this.

Copy link
Collaborator

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the tests run with the GA provider passed- merging

@SarahFrench SarahFrench merged commit 6a47977 into GoogleCloudPlatform:main May 8, 2024
16 checks passed
kautikdk pushed a commit to kautikdk/magic-modules that referenced this pull request May 16, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants