Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud_sql_target field in google_data_loss_prevention_discovery_config #10625

Merged
merged 2 commits into from
May 9, 2024

Conversation

patrickmoy
Copy link
Member

Release Note Template for Downstream PRs (will be copied)

dlp: added `cloud_sql_target` field to `google_data_loss_prevention_discovery_config` resource

@patrickmoy patrickmoy changed the title Add cloudSqlTarget field to DiscoveryConfig.yaml Add cloud_sql_target field in google_data_loss_prevention_discovery_config May 7, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1090 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 1090 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 298 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1090 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 1090 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 298 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 66
Passed tests: 64
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • datalossprevention

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataLossPreventionDiscoveryConfig_Update|TestAccDataLossPreventionDiscoveryConfig_dlpDiscoveryConfigCloudSqlExample

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 66
Passed tests: 64
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • datalossprevention

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataLossPreventionDiscoveryConfig_Update|TestAccDataLossPreventionDiscoveryConfig_dlpDiscoveryConfigCloudSqlExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataLossPreventionDiscoveryConfig_Update[Error message] [Debug log]
TestAccDataLossPreventionDiscoveryConfig_dlpDiscoveryConfigCloudSqlExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataLossPreventionDiscoveryConfig_Update[Error message] [Debug log]
TestAccDataLossPreventionDiscoveryConfig_dlpDiscoveryConfigCloudSqlExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@patrickmoy
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1090 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 1090 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 298 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 66
Passed tests: 65
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • datalossprevention

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataLossPreventionDiscoveryConfig_dlpDiscoveryConfigCloudSqlExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataLossPreventionDiscoveryConfig_dlpDiscoveryConfigCloudSqlExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@patrickmoy patrickmoy marked this pull request as ready for review May 7, 2024 22:52
@github-actions github-actions bot requested a review from slevenick May 7, 2024 22:53
Copy link

github-actions bot commented May 7, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just some minor notes. Thanks for adding an update test for this!

@patrickmoy patrickmoy requested a review from slevenick May 8, 2024 21:01
@patrickmoy
Copy link
Member Author

Made indentation changes, added required tag, and squashed fixes into 1 commit (total = 2: 1 base commit to add support, 1 commit with feedback fixes)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1090 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 1090 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 298 insertions(+))

2 similar comments
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1090 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 1090 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 298 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1090 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 1090 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 298 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 66
Passed tests: 66
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • datalossprevention

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1090 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 1090 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 298 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 66
Passed tests: 66
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • datalossprevention

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1090 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 1090 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 298 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 66
Passed tests: 66
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • datalossprevention

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 66
Passed tests: 66
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • datalossprevention

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 66
Passed tests: 66
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • datalossprevention

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@slevenick slevenick merged commit 87fd42d into GoogleCloudPlatform:main May 9, 2024
14 checks passed
kautikdk pushed a commit to kautikdk/magic-modules that referenced this pull request May 16, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants