Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data source for retrieving multiple GCE subnetworks #10669

Conversation

bestefreund
Copy link
Contributor

@bestefreund bestefreund commented May 11, 2024

Adds a new data source "google_compute_subnetworks", allowing to retrieve multiple GCE subnetworks.

Fixes: hashicorp/terraform-provider-google#18108

Release Note Template for Downstream PRs (will be copied)

`google_compute_subnetworks`

@github-actions github-actions bot requested a review from slevenick May 11, 2024 17:57
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 11, 2024
@bestefreund bestefreund force-pushed the feature/data_source_google_compute_subnetworks branch 5 times, most recently from fea9883 to 5c3e91d Compare May 11, 2024 21:05
@bestefreund bestefreund force-pushed the feature/data_source_google_compute_subnetworks branch from 5c3e91d to 9e7f477 Compare May 11, 2024 21:58
@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label May 13, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 330 insertions(+))
google-beta provider: Diff ( 4 files changed, 330 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 918
Passed tests: 845
Skipped tests: 72
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleSubnetworks_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleSubnetworks_basic[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@bestefreund
Copy link
Contributor Author

Hi @slevenick ,
is here anything further I can contribute?

@slevenick slevenick merged commit cb86587 into GoogleCloudPlatform:main May 16, 2024
12 checks passed
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
avijain25 pushed a commit to avijain25/magic-modules that referenced this pull request May 21, 2024
ma-g-22 pushed a commit to ma-g-22/magic-modules that referenced this pull request May 21, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add data source for retrieving multiple GCE subnets
3 participants