Add support for specifying storage pool when creating a disk. #10793
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 210 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeAddress_instanceWithIpExample|TestAccComputeAutoscaler_autoscalerBasicExample|TestAccComputeAutoscaler_autoscalerSingleInstanceExample|TestAccComputeAutoscaler_multicondition|TestAccComputeAutoscaler_scaleDownControl|TestAccComputeAutoscaler_scaleInControl|TestAccComputeAutoscaler_scaleInControlFixed|TestAccComputeAutoscaler_scalingSchedule|TestAccComputeAutoscaler_update|TestAccComputeBackendService_withBackend|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_withBackendAndMaxUtilization|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeDiskResourcePolicyAttachment_diskResourcePolicyAttachmentBasicExample|TestAccComputeDiskResourcePolicyAttachment_update|TestAccComputeDisk_cloneDisk|TestAccComputeDisk_deleteDetach|TestAccComputeDisk_encryptionKMS|TestAccComputeDisk_fromSnapshot|TestAccComputeDisk_fromTypeUrl|TestAccComputeDisk_multiWriter|TestAccComputeDisk_resourcePolicies|TestAccComputeDisk_storagePoolSpecified|TestAccComputeDisk_update|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeImage_basedondisk|TestAccComputeImage_imageEncryptionKey|TestAccComputeImage_sourceImage|TestAccComputeImage_sourceSnapshot|TestAccComputeImage_withLicense|TestAccComputeInstanceGroup_basic|TestAccComputeInstanceGroup_rename|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeInstanceTemplate_EncryptKMS|TestAccComputeInstanceTemplate_IP|TestAccComputeInstanceTemplate_IPv6|TestAccComputeInstanceTemplate_NetworkAttachment|TestAccComputeInstanceTemplate_basic|TestAccComputeInstanceTemplate_diskIops|TestAccComputeInstanceTemplate_diskResourcePolicies|TestAccComputeInstanceTemplate_disks|TestAccComputeInstanceTemplate_enableDisplay|TestAccComputeInstanceTemplate_guestAccelerator|TestAccComputeInstanceTemplate_instanceResourcePolicies|TestAccComputeInstanceTemplate_localSsdRecoveryTimeout|TestAccComputeInstanceTemplate_maintenance_interval|TestAccComputeInstanceTemplate_managedEnvoy|TestAccComputeInstanceTemplate_maxRunDuration_onInstanceStopAction|TestAccComputeInstanceTemplate_minCpuPlatform|TestAccComputeInstanceTemplate_networkIP|TestAccComputeInstanceTemplate_networkIPAddress|TestAccComputeInstanceTemplate_networkTier|TestAccComputeInstanceTemplate_preemptible|TestAccComputeInstanceTemplate_primaryAliasIpRange|TestAccComputeInstanceTemplate_regionDisks|TestAccComputeInstanceTemplate_reservationAffinities|TestAccComputeInstanceTemplate_secondaryAliasIpRange|TestAccComputeInstanceTemplate_shieldedVmConfig1|TestAccComputeInstanceTemplate_shieldedVmConfig2|TestAccComputeInstanceTemplate_soleTenantNodeAffinities|TestAccComputeInstanceTemplate_sourceImageEncryptionKey|TestAccComputeInstanceTemplate_sourceSnapshotEncryptionKey|TestAccComputeInstanceTemplate_spot|TestAccComputeInstanceTemplate_spot_maxRunDuration|TestAccComputeInstanceTemplate_spot_maxRunDuration_deleteTerminationAction|TestAccComputeInstanceTemplate_spot_maxRunDuration_stopTerminationAction|TestAccComputeInstanceTemplate_subnet_auto|TestAccComputeInstanceTemplate_subnet_custom|TestAccComputeInstanceTemplate_with18TbScratchDisk|TestAccComputeInstanceTemplate_withScratchDisk|TestAccComputeInstance_IPv6|TestAccComputeInstance_NetworkAttachmentUpdate|TestAccComputeInstance_NicStackTypeUpdate|TestAccComputeInstance_PTRRecord|TestAccComputeInstance_advancedMachineFeatures|TestAccComputeInstance_attachedDisk|TestAccComputeInstance_attachedDisk_modeRo|TestAccComputeInstance_attachedDisk_sourceUrl|TestAccComputeInstance_basic1|TestAccComputeInstance_bootDisk_mode|TestAccComputeInstance_bootDisk_source|TestAccComputeInstance_bootDisk_sourceUrl|TestAccComputeInstance_confidentialHyperDiskBootDisk|TestAccComputeInstance_deletionProtectionExplicitTrueAndUpdateFalse|TestAccComputeInstance_enableDisplay|TestAccComputeInstance_forceChangeMachineTypeManually|TestAccComputeInstance_guestAccelerator|TestAccComputeInstance_hostname|TestAccComputeInstance_hyperdiskBootDisk_provisioned_iops_throughput|TestAccComputeInstance_internalIPv6|TestAccComputeInstance_ipv6ExternalReservation|TestAccComputeInstance_kmsDiskEncryption|TestAccComputeInstance_localSsdRecoveryTimeout|TestAccComputeInstance_localSsdRecoveryTimeout_update|TestAccComputeInstance_maxRunDuration_update|TestAccComputeInstance_minCpuPlatform|TestAccComputeInstance_multiNic|TestAccComputeInstance_networkTier|TestAccComputeInstance_primaryAliasIpRange|TestAccComputeInstance_queueCount|TestAccComputeInstance_reservationAffinities|TestAccComputeInstance_resourcePolicyCollocate|TestAccComputeInstance_scheduling|TestAccComputeInstance_secondaryAliasIpRange|TestAccComputeInstance_serviceAccount|TestAccComputeInstance_serviceAccount_updated|TestAccComputeInstance_serviceAccount_updated0to1to0scopes|TestAccComputeInstance_shieldedVmConfig|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeInstance_spotVM|TestAccComputeInstance_spotVM_maxRunDuration_deleteTerminationAction|TestAccComputeInstance_spotVM_maxRunDuration_update|TestAccComputeInstance_spotVM_update|TestAccComputeInstance_standardVM_maxRunDuration_deleteTerminationAction|TestAccComputeInstance_standardVM_maxRunDuration_stopTerminationAction|TestAccComputeInstance_stopInstanceToUpdate|TestAccComputeInstance_subnet_auto|TestAccComputeInstance_subnet_custom|TestAccComputeInstance_subnetworkUpdate|TestAccComputeInstance_with375GbScratchDisk|TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample|TestAccComputeInterconnect_computeInterconnectBasicTestExample|TestAccComputeNodeTemplate_nodeTemplateServerBindingExample|TestAccComputePerInstanceConfig_removeInstanceOnDestroy|TestAccComputePerInstanceConfig_statefulIps|TestAccComputePerInstanceConfig_update|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionAutoscaler_scaleInControl|TestAccComputeRegionAutoscaler_scalingSchedule|TestAccComputeRegionAutoscaler_update|TestAccComputeRegionBackendService_ilbUpdateFull|TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_withBackendInternalManaged|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionDiskResourcePolicyAttachment_regionDiskResourcePolicyAttachmentBasicExample|TestAccComputeRegionInstanceTemplate_IP|TestAccComputeRegionInstanceTemplate_IPv6|TestAccComputeRegionInstanceTemplate_basic|TestAccComputeRegionInstanceTemplate_diskIops|TestAccComputeRegionInstanceTemplate_diskResourcePolicies|TestAccComputeRegionInstanceTemplate_enableDisplay|TestAccComputeRegionInstanceTemplate_guestAccelerator|TestAccComputeRegionInstanceTemplate_instanceResourcePolicies|TestAccComputeRegionInstanceTemplate_localSsdRecoveryTimeout|TestAccComputeRegionInstanceTemplate_maintenance_interval|TestAccComputeRegionInstanceTemplate_managedEnvoy|TestAccComputeRegionInstanceTemplate_maxRunDuration_onInstanceStopAction|TestAccComputeRegionInstanceTemplate_minCpuPlatform|TestAccComputeRegionInstanceTemplate_networkIP|TestAccComputeRegionInstanceTemplate_networkIPAddress|TestAccComputeRegionInstanceTemplate_networkTier|TestAccComputeRegionInstanceTemplate_preemptible|TestAccComputeRegionInstanceTemplate_primaryAliasIpRange|TestAccComputeRegionInstanceTemplate_regionDisks|TestAccComputeRegionInstanceTemplate_reservationAffinities|TestAccComputeRegionInstanceTemplate_secondaryAliasIpRange|TestAccComputeRegionInstanceTemplate_shieldedVmConfig1|TestAccComputeRegionInstanceTemplate_shieldedVmConfig2|TestAccComputeRegionInstanceTemplate_soleTenantNodeAffinities|TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey|TestAccComputeRegionInstanceTemplate_sourceSnapshotEncryptionKey|TestAccComputeRegionInstanceTemplate_spot|TestAccComputeRegionInstanceTemplate_spot_maxRunDuration|TestAccComputeRegionInstanceTemplate_subnet_auto|TestAccComputeRegionInstanceTemplate_subnet_custom|TestAccComputeRegionInstanceTemplate_with18TbScratchDisk|TestAccComputeRegionInstanceTemplate_withScratchDisk|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccComputeRegionPerInstanceConfig_statefulIps|TestAccComputeRegionPerInstanceConfig_update|TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyMtlsExample|TestAccComputeResourcePolicy_attached|TestAccComputeRoute_hopInstance|TestAccComputeSnapshotIamBindingGenerated|TestAccComputeSnapshotIamMemberGenerated|TestAccComputeSnapshotIamPolicyGenerated|TestAccComputeSnapshot_encryption|TestAccComputeSnapshot_snapshotBasicExample|TestAccComputeSnapshot_snapshotChainnameExample|TestAccComputeTargetHttpsProxy_targetHttpsProxyMtlsExample|TestAccComputeTargetInstance_targetInstanceBasicExample|TestAccComputeTargetInstance_targetInstanceCustomNetworkExample|TestAccComputeTargetInstance_targetInstanceWithSecurityPolicyExample|TestAccComputeTargetInstance_withSecurityPolicy|TestAccComputeTargetPool_basic|TestAccInstanceGroupManager_autoHealingPolicies|TestAccInstanceGroupManager_basic|TestAccInstanceGroupManager_resourceManagerTags|TestAccInstanceGroupManager_self_link_unique|TestAccInstanceGroupManager_stateful|TestAccInstanceGroupManager_targetSizeZero|TestAccInstanceGroupManager_update|TestAccInstanceGroupManager_versions|TestAccInstanceGroupManager_waitForStatus|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccRegionInstanceGroupManager_basic|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccRegionInstanceGroupManager_resourceManagerTags|TestAccRegionInstanceGroupManager_stateful|TestAccRegionInstanceGroupManager_targetSizeZero|TestAccRegionInstanceGroupManager_update|TestAccRegionInstanceGroupManager_versions |
sizzle0121
force-pushed
the
storage-pool-disk-support
branch
from
1f2ef3c to
541781f
Compare
|
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeInstance_guestAccelerator|TestAccComputeInterconnect_computeInterconnectBasicTestExample |
|
|
|
Hi @c2thorn, I think the failed tests are not related to my changes, please review, thanks! |
|
This PR has been waiting for review for 2 weekdays. Please take a look! Use the label |
| cleanupTestingStoragePool(t, storagePoolName) | ||
| } | ||
|
|
||
| func setupTestingStoragePool(t *testing.T, storagePoolName string) func() { |
There was a problem hiding this comment.
Should Compute storage pool be a Terraform resource eventually?
|
re-running tests to hopefully avoid some of the flakey tests |
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeInstance_guestAccelerator |
|
|
Add field
storage_pooltogoogle_compute_diskresource to support creating disk with the storage pool in which it will reside.Instead of adding a resource for storage pool and using resourceRef to let disk reference it, we add the field as a string which will contain the URL for a storage pool. The main reason for this decision is that if we add storage pool as a resource, and in the scenario that users want to destroy a storage pool, Terraform will plan to delete all disks first and then delete the storage pool, which we definitely want to prevent from happening.
Therefore, we eventually decided to not support creating storage pool via Terraform, and only support adding the field for disks to specify existing storage pool. The management of storage pool itself will remain through GCP APIs.