Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flexibleRuntimeSettings to app engine flexible #10795

Merged
merged 8 commits into from
Jun 4, 2024

Conversation

kennethye1
Copy link
Contributor

@kennethye1 kennethye1 commented May 24, 2024

Add new flexibleRuntimeSettings field to App Engine flexible.

Corresponds to https://cloud.google.com/appengine/docs/admin-api/reference/rest/v1/apps.services.versions#flexibleruntimesettings.

See: hashicorp/terraform-provider-google#16447

appengine: added field `flexible_runtime_settings` to resource `google_app_engine_flexible_app_version` resource

@github-actions github-actions bot requested a review from trodge May 24, 2024 21:13
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@kennethye1 kennethye1 changed the title Add flexibleRuntimeSettings to terraform Add flexibleRuntimeSettings to app engine flexible May 24, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 112 insertions(+))
google-beta provider: Diff ( 3 files changed, 112 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 14
Passed tests: 13
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • appengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAppEngineFlexibleAppVersion_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 116 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 116 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • appengine

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAppEngineFlexibleAppVersion_update|TestAccAppEngineStandardAppVersion_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAppEngineStandardAppVersion_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

Copy link

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@trodge
Copy link
Contributor

trodge commented May 28, 2024

The test is failing with the following error:

---[ REQUEST ]---------------------------------------
GET /v1/apps/tf-test-appeng-flexc4q6xh1yj1/operations/9b929b60-3b78-4a68-9aaa-3b7026fc8889?alt=json&prettyPrint=false HTTP/1.1
Host: appengine.googleapis.com
User-Agent: google-api-go-client/0.5 Terraform/1.8.3 (+https://www.terraform.io) Terraform-Plugin-SDK/2.33.0 terraform-provider-google-beta/acc
X-Goog-Api-Client: gl-go/1.21.10 gdcl/0.177.0
Accept-Encoding: gzip


-----------------------------------------------------
2024/05/24 22:23:41 [DEBUG] Google API Response Details:
---[ RESPONSE ]--------------------------------------
HTTP/2.0 200 OK
Cache-Control: private
Content-Type: application/json; charset=UTF-8
Date: Fri, 24 May 2024 22:23:41 GMT
Server: ESF
Vary: Origin
Vary: X-Origin
Vary: Referer
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Xss-Protection: 0

{
 "name": "apps/tf-test-appeng-flexc4q6xh1yj1/operations/9b929b60-3b78-4a68-9aaa-3b7026fc8889",
 "metadata": {
  "@type": "type.googleapis.com/google.appengine.v1beta.OperationMetadataV1Beta",
  "method": "google.appengine.v1beta.Versions.CreateVersion",
  "insertTime": "2024-05-24T22:22:40.497Z",
  "user": "hashicorp-test-runner@ci-test-project-188019.iam.gserviceaccount.com",
  "target": "apps/tf-test-appeng-flexc4q6xh1yj1/services/custom/versions/v1",
  "warning": [
   "python 3.7 and earlier versions will reach end of support on 2024-07-10 for App Engine flexible environment. After 2024-07-10, you cannot deploy new or re-deploy existing applications that use runtimes after their end of support date. We recommend that you migrate to the latest supported version of python."
  ],
  "createVersionMetadata": {
   "cloudBuildId": "26d9de2f-8c8e-40aa-9e5c-451fe26fa7db"
  }
 },
 "done": true,
 "error": {
  "code": 9,
  "message": "Cloud build 26d9de2f-8c8e-40aa-9e5c-451fe26fa7db status: FAILURE\nBuild error details: Build error details not available.\nFull build logs: https://console.cloud.google.com/cloud-build/builds/26d9de2f-8c8e-40aa-9e5c-451fe26fa7db?project=938572994124"
 }
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 116 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 5 files changed, 116 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 14
Passed tests: 13
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • appengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAppEngineFlexibleAppVersion_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 116 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 116 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • appengine

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAppEngineFlexibleAppVersion_update|TestAccAppEngineStandardAppVersion_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Debug log]

$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@trodge
Copy link
Contributor

trodge commented May 30, 2024

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 116 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 116 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 14
Passed tests: 13
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • appengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAppEngineStandardAppVersion_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 122 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 122 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 14
Passed tests: 13
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • appengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAppEngineStandardAppVersion_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@github-actions github-actions bot requested a review from trodge May 31, 2024 00:04
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 116 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 116 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 14
Passed tests: 13
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • appengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAppEngineStandardAppVersion_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

Copy link

github-actions bot commented Jun 3, 2024

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@trodge
Copy link
Contributor

trodge commented Jun 3, 2024

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 116 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 116 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • appengine

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAppEngineFlexibleAppVersion_update|TestAccAppEngineStandardAppVersion_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Debug log]
TestAccAppEngineStandardAppVersion_update[Debug log]

$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 121 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 121 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 14
Passed tests: 13
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • appengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAppEngineFlexibleAppVersion_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Debug log]

$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 123 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 123 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 40 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 14
Passed tests: 13
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • appengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAppEngineFlexibleAppVersion_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants