Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed required tag on maxFindingsPerInfoType.infoType #10818

Merged
merged 2 commits into from
May 31, 2024
Merged

Removed required tag on maxFindingsPerInfoType.infoType #10818

merged 2 commits into from
May 31, 2024

Conversation

patrickmoy
Copy link
Member

@patrickmoy patrickmoy commented May 29, 2024

Fixes hashicorp/terraform-provider-google#18149

dlp: removed required on  `google_data_loss_prevention_inspect_template` to allow use of default `per_info_type` limit by not setting the `info_type` field

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 7 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 2 files changed, 7 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 66
Passed tests: 66
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • datalossprevention

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@patrickmoy patrickmoy marked this pull request as ready for review May 29, 2024 17:05
@github-actions github-actions bot requested a review from slevenick May 29, 2024 17:05
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@patrickmoy
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 7 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 2 files changed, 7 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 66
Passed tests: 66
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • datalossprevention

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test that doesn't specify this field just so we can make sure it all works as expected?

@github-actions github-actions bot requested a review from slevenick May 29, 2024 21:23
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 7 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 2 files changed, 7 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 66
Passed tests: 66
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • datalossprevention

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 87 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 3 files changed, 87 insertions(+), 7 deletions(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 87 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 3 files changed, 87 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 67
Passed tests: 66
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • datalossprevention

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataLossPreventionInspectTemplate_dlpInspectTemplateMaxInfotypePerFindingDefaultExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataLossPreventionInspectTemplate_dlpInspectTemplateMaxInfotypePerFindingDefaultExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 67
Passed tests: 66
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • datalossprevention

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataLossPreventionInspectTemplate_dlpInspectTemplateMaxInfotypePerFindingDefaultExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataLossPreventionInspectTemplate_dlpInspectTemplateMaxInfotypePerFindingDefaultExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 87 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 3 files changed, 87 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 67
Passed tests: 66
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • datalossprevention

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataLossPreventionInspectTemplate_dlpInspectTemplateMaxInfotypePerFindingDefaultExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataLossPreventionInspectTemplate_dlpInspectTemplateMaxInfotypePerFindingDefaultExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@patrickmoy
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 87 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 3 files changed, 87 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 67
Passed tests: 67
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • datalossprevention

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@patrickmoy
Copy link
Member Author

Added test that excludes the formerly required field

Copy link

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DLP inspect template resource not allowing "default" per_info_type limit
3 participants