Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert iam test template with Go #10824

Merged
merged 1 commit into from
May 29, 2024

Conversation

zli82016
Copy link
Member

Will rewrite iam_context.go.erb later.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@zli82016 zli82016 requested a review from c2thorn May 29, 2024 18:01
return (r.ProductMetadata.VersionObjOrClosest(r.TargetVersionName).CompareTo(r.ProductMetadata.VersionObjOrClosest(e.MinVersion)) < 0)
})

return examples[0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't realize we did this!

@zli82016 zli82016 merged commit 1c8ae12 into GoogleCloudPlatform:main May 29, 2024
11 checks passed
@zli82016 zli82016 deleted the go-rewrite-iam-test branch May 29, 2024 21:28
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
jessdejong pushed a commit to jessdejong/magic-modules that referenced this pull request Jun 10, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants