Unset operation when reading instance_group_manager resource

[askubis]

fixes hashicorp/terraform-provider-google#16043
It is reverting a change done by refactoring in hashicorp/terraform-provider-google-beta@79e0a2e#diff-1cf6fdb65a48539ac4730b8920d0366d3a173b7e824b08502d3c3da73456d8f8

Release Note Template for Downstream PRs (will be copied)

compute: fixed an issue where `google_compute_instance_group_manager` with a pending operation was incorrectly removed due to the operation no longer being present in the backend

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 940
Passed tests: 866
Skipped tests: 72
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeInstance_guestAccelerator

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccComputeInstance_guestAccelerator[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[github-actions]

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[c2thorn]

I cannot find the context for this change. Is there a better link? The current one links to a seemingly random commit that is very large.

Also, is this related to a Github issue in https://github.com/hashicorp/terraform-provider-google/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc ?

[askubis]

I cannot find the context for this change. Is there a better link? The current one links to a seemingly random commit that is very large.

Also, is this related to a Github issue in https://github.com/hashicorp/terraform-provider-google/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc ?

the context is hashicorp/terraform-provider-google#16043

what the commit is mentioning is google-beta/resource_compute_instance_group_manager.go

-               d.Set("operation", "")
+		if err := d.Set("operation", op.Name); err != nil {
+			return fmt.Errorf("Error setting operation: %s", err)
+		}

which seems to be a copy-paste error, as the previous change in the same file is correct:

-			d.Set("operation", op.Name)
+			if err := d.Set("operation", op.Name); err != nil {
+				return fmt.Errorf("Error setting operation: %s", err)
+			}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 952
Passed tests: 877
Skipped tests: 74
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[github-actions]

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[c2thorn]

hashicorp/terraform-provider-google#16043

I see, thank you.