Add GA support for confidentialInstanceType

[deeglaze]

Finalizes hashicorp/terraform-provider-google#14768
Fixes b/345255719

compute: added `confidential_instance_config.confidential_instance_type` field to `google_compute_instance`,  `google_compute_instance_template`, and `google_compute_region_instance_template` resources

[deeglaze]

/cc @NickElliot

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 356 insertions(+), 17 deletions(-))
google-beta provider: Diff ( 3 files changed, 3 insertions(+), 3 deletions(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[github-actions]

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[deeglaze]

Changed to draft since the GA json change hasn't propagated to the Golang derived API package yet.

[c2thorn]

Changed to draft since the GA json change hasn't propagated to the Golang derived API package yet.

please ping me when this is ready for review

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 356 insertions(+), 17 deletions(-))
google-beta provider: Diff ( 3 files changed, 3 insertions(+), 3 deletions(-))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 359 insertions(+), 20 deletions(-))
google-beta provider: Diff ( 5 files changed, 6 insertions(+), 6 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 402 insertions(+), 63 deletions(-))
google-beta provider: Diff ( 5 files changed, 49 insertions(+), 49 deletions(-))

[modular-magician]

Tests analytics

Total tests: 6871
Passed tests: 3435
Skipped tests: 376
Affected tests: 1

Click here to see the affected service packages

All service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 402 insertions(+), 63 deletions(-))
google-beta provider: Diff ( 5 files changed, 49 insertions(+), 49 deletions(-))

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 6871
Passed tests: 3435
Skipped tests: 376
Affected tests: 1

Click here to see the affected service packages

All service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 402 insertions(+), 63 deletions(-))
google-beta provider: Diff ( 5 files changed, 49 insertions(+), 49 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 403 insertions(+), 63 deletions(-))
google-beta provider: Diff ( 5 files changed, 49 insertions(+), 49 deletions(-))

[modular-magician]

Tests analytics

Total tests: 6870
Passed tests: 3434
Skipped tests: 376
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccAppEngineFlexibleAppVersion_update
• TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

[deeglaze]

@c2thorn the TestReadPlannedAssetsCoverage failure appears to be unrelated. The rest is good to go I think.

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 6870
Passed tests: 3434
Skipped tests: 376
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccAppEngineFlexibleAppVersion_update
• TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[c2thorn]

can you try rebasing/pulling this branch to after #11037. This should fix the unit test failure

[c2thorn]

is this upgrade needed to support the field in GA?

[deeglaze]

It is. The ConfidentialInstanceType field was added to the GA API very recently.

[c2thorn]

even if this field has been made obsolete, removing fields are a breaking change as users may be using it in TF schema. You can deprecate the field and follow up with removal by following https://googlecloudplatform.github.io/magic-modules/develop/breaking-changes/make-a-breaking-change/#add-deprecations-and-warnings-to-the-main-branch-of-magic-modules

[deeglaze]

I'm not removing it. The else condition is just becoming active. Is the Required: True what needs to remain until a major release can fully deprecate it? I've added a deprecation message in another commit at least.

[c2thorn]

Ahh, I misread the block. Got it!
No, it is not a breaking change to remove a requirement (only the reverse)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 403 insertions(+), 63 deletions(-))
google-beta provider: Diff ( 5 files changed, 49 insertions(+), 49 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3815
Passed tests: 3436
Skipped tests: 376
Affected tests: 3

Click here to see the affected service packages

All service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccAppEngineFlexibleAppVersion_update
• TestAccBigQueryRoutine_bigQueryRoutineRemoteFunction
• TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryRoutine_bigQueryRoutineRemoteFunction[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[c2thorn]

This is a very version-specific change, so I'm going to run tests in our separate GA environment as well just to be sure. If everything's good I'll come back and merge

[deeglaze]

Thanks @c2thorn!

[c2thorn]

Tests look good, failures were not relevant. LGTM