feat(billingbudget): support project level recicipients on budgets

[renescheepers]

Support for setting the project level recipients: https://cloud.google.com/billing/docs/reference/budget/rest/v1beta1/billingAccounts.budgets#allupdatesrule.

FIXES hashicorp/terraform-provider-google#18182

billingbudget: added `enable_project_level_recipients` field to `google_billing_budget` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[c2thorn]

Can you add a test (or add to an existing test) where the new field updates? https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/services/billing/resource_billing_budget_test.go

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 36 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 2 files changed, 36 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_billing_budget (16 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_billing_budget" "primary" {
  all_updates_rule {
    enable_project_level_recipients = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 15
Passed tests: 13
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

• billing

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBillingBudget_billingBudgetUpdate

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBillingBudget_billingBudgetUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 124 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 124 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 14
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

• billing

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBillingBudget_billingBudgetNotifyProjectRecipientExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccBillingBudget_billingBudgetNotifyProjectRecipientExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[c2thorn]

    vcr_utils.go:152: Step 1/2 error: Error running pre-apply refresh: exit status 1
        
        Error: Missing required argument
        
          with google_billing_budget.budget,
          on terraform_plugin_test.tf line 24, in resource "google_billing_budget" "budget":
          24:   all_updates_rule {
        
        "all_updates_rule.0.monitoring_notification_channels": one of
        `all_updates_rule.0.monitoring_notification_channels,all_updates_rule.0.pubsub_topic`
        must be specified
        
        Error: Missing required argument
        
          with google_billing_budget.budget,
          on terraform_plugin_test.tf line 24, in resource "google_billing_budget" "budget":
          24:   all_updates_rule {
        
        "all_updates_rule.0.pubsub_topic": one of
        `all_updates_rule.0.monitoring_notification_channels,all_updates_rule.0.pubsub_topic`
        must be specified

[renescheepers]

I can't properly test this on my personal account and don't really want to run these tests against a real billing account. The test probably requires an organisation account.

When running a test I haven't touched:

I've instead just tried applying this Terraform, which should be the same as in the acceptance test:

resource "google_billing_budget" "budget" {
  count = local.billing_account != null ? 1 : 0 # Only create budget if billing is enabled.

  billing_account = local.billing_account
  display_name    = format("Starter budget for %s", google_project.current.project_id)
  budget_filter {
    credit_types_treatment = "EXCLUDE_ALL_CREDITS"
    projects               = ["projects/${google_project.current.number}"]
  }
  amount {
    specified_amount {
      currency_code = "USD"
      units         = tostring(var.billing_budget)
    }
  }
  threshold_rules {
    threshold_percent = 1.0
  }

  all_updates_rule {

    monitoring_notification_channels = []
    enable_project_level_recipients = false
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 126 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 126 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

[modular-magician]

Tests analytics

Total tests: 16
Passed tests: 14
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

• billing

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBillingBudget_billingBudgetNotifyProjectRecipientExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBillingBudget_billingBudgetNotifyProjectRecipientExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[c2thorn]

LGTM, thank you for the contribution