-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated description of connection_draining_timeout_sec, balancing_mode and outlier_detection in backend_service and regional_backend_service before changing defaults #10927
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeInstanceNetworkIntefaceWithSecurityPolicy |
|
@@ -658,6 +658,7 @@ properties: | |||
description: | | |||
Time for which instance will be drained (not accept new | |||
connections, but still work to finish started). | |||
deprecation_message: "connection_draining_timeout_sec default value will be changed to 300 to match default GCP value" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terraform deprecations messages are highly disruptive for users and should be reserved for fields that will actually be removed. I quickly conferred with the team, and we don't believe we should use it here. Can we just add an upgrade guide entry + maybe mention in documentation description?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. I have removed the deprecation_message and added info to docs about the changes coming in 6.0.0.
e5622e4
to
6efdf79
Compare
…e and outlier_detection in backend_service and regional_backend_service
6efdf79
to
133a0ef
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeInstanceNetworkIntefaceWithSecurityPolicy |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy |
|
|
…e and outlier_detection in backend_service and regional_backend_service before changing defaults (GoogleCloudPlatform#10927)
…e and outlier_detection in backend_service and regional_backend_service before changing defaults (GoogleCloudPlatform#10927)
Adds info in the description of
connection_draining_timeout_sec
,balancing_mode
andoutlier_detection
about breaking change in the next major release.hashicorp/terraform-provider-google#13478
hashicorp/terraform-provider-google#12299
hashicorp/terraform-provider-google#15210
hashicorp/terraform-provider-google#17257
Release Note Template for Downstream PRs (will be copied)