Updated description of connection_draining_timeout_sec, balancing_mode and outlier_detection in backend_service and regional_backend_service before changing defaults

[pawelJas]

Adds info in the description of connection_draining_timeout_sec, balancing_mode and outlier_detection about breaking change in the next major release.

hashicorp/terraform-provider-google#13478
hashicorp/terraform-provider-google#12299
hashicorp/terraform-provider-google#15210
hashicorp/terraform-provider-google#17257

Release Note Template for Downstream PRs (will be copied)

compute: Updated field description of `connection_draining_timeout_sec`, `balancing_mode` and `outlier_detection` in `google_compute_region_backend_service` and `google_compute_backend_service`  to inform that default values will be changed

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 6 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 6 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 956
Passed tests: 881
Skipped tests: 74
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[c2thorn]

Terraform deprecations messages are highly disruptive for users and should be reserved for fields that will actually be removed. I quickly conferred with the team, and we don't believe we should use it here. Can we just add an upgrade guide entry + maybe mention in documentation description?

[pawelJas]

Understood. I have removed the deprecation_message and added info to docs about the changes coming in 6.0.0.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 24 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 4 files changed, 24 insertions(+), 5 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 24 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 4 files changed, 24 insertions(+), 5 deletions(-))

[modular-magician]

Tests analytics

Total tests: 956
Passed tests: 881
Skipped tests: 74
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 956
Passed tests: 880
Skipped tests: 74
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test