Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix google_access_context_manager_service_perimeters permadiff #10965

Merged

Conversation

Charlesleonius
Copy link
Member

Implement custom flatten for google_access_context_manager_service_perimeters as ordering my change server side which can cause a permadiff.

Permadiff is causing tests to fail consistently: hashicorp/terraform-provider-google#17370

accesscontextmanager: Implement custom flatten for google_access_context_manager_service_perimeters as ordering my change server side which can cause a permadiff.

…rimeters as ordering my change server side which can cause a permadiff.
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 26 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 2 files changed, 26 insertions(+), 13 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 1
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages
  • accesscontextmanager

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

Copy link

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@BBBmau BBBmau merged commit fb2c2dc into GoogleCloudPlatform:main Jun 22, 2024
14 checks passed
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 24, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
vijaykanthm pushed a commit to vijaykanthm/magic-modules that referenced this pull request Jul 22, 2024
Charlesleonius added a commit to Charlesleonius/magic-modules that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants