-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix google_access_context_manager_service_perimeters permadiff #10965
fix google_access_context_manager_service_perimeters permadiff #10965
Conversation
…rimeters as ordering my change server side which can cause a permadiff.
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
|
@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label |
…eCloudPlatform#10965) Co-authored-by: Charlesleonius <charlesleon@google.com>
…eCloudPlatform#10965) Co-authored-by: Charlesleonius <charlesleon@google.com>
…eCloudPlatform#10965) Co-authored-by: Charlesleonius <charlesleon@google.com>
…eCloudPlatform#10965) Co-authored-by: Charlesleonius <charlesleon@google.com>
Implement custom flatten for google_access_context_manager_service_perimeters as ordering my change server side which can cause a permadiff.
Permadiff is causing tests to fail consistently: hashicorp/terraform-provider-google#17370