Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Pub/Sub Subscription support for specifying a service account #10967

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

kamalaboulhosn
Copy link
Contributor

@kamalaboulhosn kamalaboulhosn commented Jun 14, 2024

Add Pub/Sub Subscription support for specifying a service account for BigQuery and Cloud Storage export subscriptions

Release Note Template for Downstream PRs (will be copied)

pubsub: added `bigquery_config.service_account_email` field to `google_pubsub_subscription` resource

…nt for BigQuery and Cloud Storage export subscriptions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 499 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 4 files changed, 499 insertions(+), 13 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 22 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 304 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 49
Passed tests: 44
Skipped tests: 1
Affected tests: 4

Click here to see the affected service packages
  • pubsub

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccPubsubSubscriptionBigQuery_serviceAccount|TestAccPubsubSubscriptionCloudStorage_serviceAccount|TestAccPubsubSubscription_pubsubSubscriptionPushBqServiceAccountExample|TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageServiceAccountExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccPubsubSubscriptionBigQuery_serviceAccount[Debug log]
TestAccPubsubSubscriptionCloudStorage_serviceAccount[Debug log]
TestAccPubsubSubscription_pubsubSubscriptionPushBqServiceAccountExample[Debug log]
TestAccPubsubSubscription_pubsubSubscriptionPushCloudstorageServiceAccountExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants