-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CMEK datasets to terraform. #10978
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
@hao-nan-li Can you please review the change. Thank you. |
@hao-nan-li This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccHealthcareDataset_healthcareDatasetCmekExample |
|
I ran the lint and tests locally and they were passing. I am guessing that these were failing since the API changes were not fully rolled out, but they are now: https://cloud.google.com/healthcare-api/docs/reference/rest/v1beta1/projects.locations.datasets. Can you please take another look at this. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 76 Click here to see the affected service packages
View the build log |
Fixes
terraform-google-modules/terraform-google-healthcare#102.
Release Note Template for Downstream PRs (will be copied)