Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CMEK datasets to terraform. #10978

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

abhisheksinghigoog
Copy link
Contributor

@abhisheksinghigoog abhisheksinghigoog commented Jun 17, 2024

Fixes
terraform-google-modules/terraform-google-healthcare#102.

Release Note Template for Downstream PRs (will be copied)

healthcare: added `encryptionSpec` field to `google_healthcare_dataset` resource

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from hao-nan-li June 17, 2024 14:16
@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jun 17, 2024
@abhisheksinghigoog
Copy link
Contributor Author

@hao-nan-li Can you please review the change. Thank you.

Copy link

@hao-nan-li This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician added service/healthcare and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Jun 20, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 191 insertions(+))
google-beta provider: Diff ( 3 files changed, 191 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 29 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 135 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 38
Passed tests: 37
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • healthcare

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccHealthcareDataset_healthcareDatasetCmekExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccHealthcareDataset_healthcareDatasetCmekExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@abhisheksinghigoog
Copy link
Contributor Author

I ran the lint and tests locally and they were passing.

I am guessing that these were failing since the API changes were not fully rolled out, but they are now: https://cloud.google.com/healthcare-api/docs/reference/rest/v1beta1/projects.locations.datasets.

Can you please take another look at this.

@github-actions github-actions bot requested a review from hao-nan-li June 24, 2024 13:41
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Jun 24, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 192 insertions(+))
google-beta provider: Diff ( 3 files changed, 192 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 29 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 135 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 76
Passed tests: 38
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • healthcare

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Charlesleonius pushed a commit to Charlesleonius/magic-modules that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants