[Terraform] DNS Policies #1108

drebes · 2018-12-26T22:00:44Z

[all]

Adds support for Cloud DNS Policies

[terraform]

[terraform-beta]

Adds support for Cloud DNS Policies

[ansible]

[inspec]

drebes · 2018-12-26T22:05:46Z

This depends on #981.

The TestAccDnsPolicy_update acceptance test is currently failing. There's something with enable_inbound_forwarding that its expansion is not being passed to the PATCH call, so it doesn't get updated server side.

$ make testacc TESTARGS='-run=TestAccDnsPolicy_update' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccDnsPolicy_update -timeout 120m -ldflags="-X=github.com/terraform-providers/terraform-provider-google-beta/version.ProviderVersion=acc"
?   	github.com/terraform-providers/terraform-provider-google-beta	[no test files]
=== RUN   TestAccDnsPolicy_update
=== PAUSE TestAccDnsPolicy_update
=== CONT  TestAccDnsPolicy_update
--- FAIL: TestAccDnsPolicy_update (67.03s)
    testing.go:538: Step 2 error: After applying this step, the plan was not empty:
        
        DIFF:
        
        UPDATE: google_dns_policy.example-policy
          enable_inbound_forwarding: "true" => "false"
        
        STATE:
        
        google_compute_network.network-1:
          ID = network-1-ojhucy1bz1
          provider = provider.google
          auto_create_subnetworks = false
          description = 
          gateway_ipv4 = 
          ipv4_range = 
          name = network-1-ojhucy1bz1
          project = drebes-playground-alpha-5ae4
          routing_mode = REGIONAL
          self_link = https://www.googleapis.com/compute/v1/projects/drebes-playground-alpha-5ae4/global/networks/network-1-ojhucy1bz1
        google_compute_network.network-2:
          ID = network-2-ojhucy1bz1
          provider = provider.google
          auto_create_subnetworks = false
          description = 
          gateway_ipv4 = 
          ipv4_range = 
          name = network-2-ojhucy1bz1
          project = drebes-playground-alpha-5ae4
          routing_mode = REGIONAL
          self_link = https://www.googleapis.com/compute/v1/projects/drebes-playground-alpha-5ae4/global/networks/network-2-ojhucy1bz1
        google_dns_policy.example-policy:
          ID = example-policy-ojhucy1bz1
          provider = provider.google
          alternative_name_server_config.# = 1
          alternative_name_server_config.0.target_name_servers.# = 1
          alternative_name_server_config.0.target_name_servers.1120708668.ipv4_address = 172.16.1.10
          description = Managed by Terraform
          enable_inbound_forwarding = true
          name = example-policy-ojhucy1bz1
          networks.# = 1
          networks.2937888432.network_url = https://www.googleapis.com/compute/v1/projects/drebes-playground-alpha-5ae4/global/networks/network-1-ojhucy1bz1
          project = drebes-playground-alpha-5ae4
        
          Dependencies:
            google_compute_network.network-1
FAIL
FAIL	github.com/terraform-providers/terraform-provider-google-beta/google-beta	67.071s
?   	github.com/terraform-providers/terraform-provider-google-beta/version	[no test files]
make: *** [testacc] Error 1

modular-magician · 2019-01-30T01:09:48Z

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

nat-henderson

This is frankly delightful - these are some of the most complex resources there are, and this looks great to me. Let's run it through the system and see what we can do about that test failure.

products/dns/api.yaml

nat-henderson · 2019-01-30T01:21:59Z

Ah, the merge conflict, of course, I see the dependency chain now. I'll wait on that issue to be closed and come back to this one.

rileykarson · 2019-02-15T23:08:37Z

@ndmckinley: This has been unblocked as #981 is merged.

drebes · 2019-02-15T23:13:41Z

I will rebase this from master.

nat-henderson · 2019-03-01T23:59:19Z

I fixed the problem that caused that test failure - I'll re-run this.

modular-magician · 2019-03-02T00:17:49Z

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 9101e2e77475369b85b5a962669af85171545d9b.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#488
depends: hashicorp/terraform-provider-google#3170

nat-henderson · 2019-03-02T00:29:23Z

Great, running those tests now.

nat-henderson · 2019-03-02T01:09:41Z

Looks like updates of

        UPDATE: google_dns_policy.example-policy
          enable_inbound_forwarding: "true" => "false"

don't stick - might need to put "send_empty_value" on that field in the terraform.yaml config?

drebes · 2019-03-03T21:53:38Z

Indeed, should be good now with the send_empty_update: true:

$ make testacc TESTARGS='-run=TestAccDnsPolicy'
==> Checking source code against gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccDnsPolicy -timeout 240m -ldflags="-X=github.com/terraform-providers/terraform-provider-google-beta/version.ProviderVersion=acc"
?   	github.com/terraform-providers/terraform-provider-google-beta	[no test files]
=== RUN   TestAccDnsPolicy_dnsPolicyBasicExample
=== PAUSE TestAccDnsPolicy_dnsPolicyBasicExample
=== RUN   TestAccDnsPolicy_update
=== PAUSE TestAccDnsPolicy_update
=== CONT  TestAccDnsPolicy_dnsPolicyBasicExample
=== CONT  TestAccDnsPolicy_update
--- PASS: TestAccDnsPolicy_dnsPolicyBasicExample (59.44s)
--- PASS: TestAccDnsPolicy_update (64.63s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google-beta/google-beta	64.663s
?   	github.com/terraform-providers/terraform-provider-google-beta/scripts/affectedtests	[no test files]
?   	github.com/terraform-providers/terraform-provider-google-beta/version	[no test files]

nat-henderson · 2019-03-04T18:22:39Z

Fantastic, sending it through again.

modular-magician · 2019-03-04T18:37:04Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 718952d.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

nat-henderson · 2019-03-04T18:38:40Z

And, testing now.

nat-henderson · 2019-03-04T20:20:22Z

Tests pass!

googlebot added the cla: yes label Dec 26, 2018

drebes force-pushed the terraform-dns-inbound branch 2 times, most recently from 0027e90 to 2f37ad1 Compare January 8, 2019 20:54

modular-magician added the community label Jan 30, 2019

nat-henderson self-assigned this Jan 30, 2019

nat-henderson reviewed Jan 30, 2019

View reviewed changes

products/dns/api.yaml Outdated Show resolved Hide resolved

drebes force-pushed the terraform-dns-inbound branch 3 times, most recently from a363812 to 33b273b Compare February 6, 2019 04:25

drebes force-pushed the terraform-dns-inbound branch from 33b273b to 66143dd Compare February 15, 2019 23:26

nat-henderson force-pushed the terraform-dns-inbound branch from 66143dd to 9101e2e Compare March 2, 2019 00:04

modular-magician added downstream-generated terraform-provider-google-beta terraform-provider-google labels Mar 2, 2019

drebes force-pushed the terraform-dns-inbound branch from 9101e2e to 718952d Compare March 3, 2019 21:50

modular-magician added the no-op label Mar 4, 2019

nat-henderson approved these changes Mar 4, 2019

View reviewed changes

modular-magician added the automerged label Mar 4, 2019

terraform: DNS policies

becacf0

modular-magician force-pushed the terraform-dns-inbound branch from 718952d to becacf0 Compare March 4, 2019 21:02

modular-magician merged commit 05c353e into GoogleCloudPlatform:master Mar 4, 2019

drebes deleted the terraform-dns-inbound branch March 4, 2019 22:29

nat-henderson mentioned this pull request Mar 15, 2019

Add DNS policy to sidebar. #1527

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Terraform] DNS Policies #1108

[Terraform] DNS Policies #1108

drebes commented Dec 26, 2018

drebes commented Dec 26, 2018

modular-magician commented Jan 30, 2019

nat-henderson left a comment

nat-henderson commented Jan 30, 2019

rileykarson commented Feb 15, 2019

drebes commented Feb 15, 2019

nat-henderson commented Mar 1, 2019

modular-magician commented Mar 2, 2019

nat-henderson commented Mar 2, 2019

nat-henderson commented Mar 2, 2019

drebes commented Mar 3, 2019

nat-henderson commented Mar 4, 2019

modular-magician commented Mar 4, 2019

nat-henderson commented Mar 4, 2019

nat-henderson commented Mar 4, 2019

[Terraform] DNS Policies #1108

[Terraform] DNS Policies #1108

Conversation

drebes commented Dec 26, 2018

[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

drebes commented Dec 26, 2018

modular-magician commented Jan 30, 2019

nat-henderson left a comment

Choose a reason for hiding this comment

nat-henderson commented Jan 30, 2019

rileykarson commented Feb 15, 2019

drebes commented Feb 15, 2019

nat-henderson commented Mar 1, 2019

modular-magician commented Mar 2, 2019

Pull request statuses

New Pull Requests

nat-henderson commented Mar 2, 2019

nat-henderson commented Mar 2, 2019

drebes commented Mar 3, 2019

nat-henderson commented Mar 4, 2019

modular-magician commented Mar 4, 2019

Pull request statuses

New Pull Requests

nat-henderson commented Mar 4, 2019

nat-henderson commented Mar 4, 2019