Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed permadiffs on environment_variables in cloudfunctions2 function #11092

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Jul 2, 2024

This change fixed permadiffs on system environment_variables in cloudfunctions2 function

It also fixed the failed tests for the resource google_cloudfunctions2_function

Release Note Template for Downstream PRs (will be copied)

cloudfunctions2: fixed permadiffs on `service_config.environment_variables` field in `google_cloudfunctions2_function` resource

@zli82016 zli82016 changed the title fixed permadiffs on service_config.environment_variables field in google_cloudfunctions2_function fixed permadiffs on environment_variables field in cloudfunctions2 function Jul 2, 2024
@zli82016 zli82016 changed the title fixed permadiffs on environment_variables field in cloudfunctions2 function fixed permadiffs on environment_variables in cloudfunctions2 function Jul 2, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+))
google-beta provider: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 17
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • cloudfunctions2

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@zli82016 zli82016 force-pushed the cloudfunctions2-environment-variables branch from b8e38bb to a17e6e9 Compare July 2, 2024 16:47
@zli82016 zli82016 force-pushed the cloudfunctions2-environment-variables branch from a17e6e9 to 2a22f9b Compare July 2, 2024 16:47
@zli82016
Copy link
Member Author

zli82016 commented Jul 2, 2024

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 20 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 1 file changed, 20 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 16 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 17
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • cloudfunctions2

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@zli82016 zli82016 requested review from a team and slevenick and removed request for a team July 2, 2024 21:15
@zli82016
Copy link
Member Author

zli82016 commented Jul 3, 2024

Tests run in CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants