Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Globaladdress.Labels to GA #11093

Conversation

mauricewittek
Copy link
Contributor

@mauricewittek mauricewittek commented Jul 2, 2024

Fixes hashicorp/terraform-provider-google#18627

Moves the GlobalAddress.Labels property and GlobalAddres.SetLabels method to GA.

Release Note Template for Downstream PRs (will be copied)

compute: move `labels` field on `google_compute_global_address` resource from Beta to GA

Copy link

google-cla bot commented Jul 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot requested a review from hao-nan-li July 2, 2024 07:57
Copy link

github-actions bot commented Jul 2, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Copy link
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you need to sign the CLA, refer to the generated message in this PR.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 214 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 3 deletions(-))

@mauricewittek
Copy link
Contributor Author

Hey @hao-nan-li, I did sign the CLA and it looks like that CI step finished successfully; cla/google Successful in 2s — ✅ All contributors are covered under a CLA with Google

Am I missing something?

@github-actions github-actions bot requested a review from hao-nan-li July 3, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move GlobalAddress.labels to GA
3 participants