Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud_storage_target field in google_data_loss_prevention_discovery_config #11139

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

patrickmoy
Copy link
Member

@patrickmoy patrickmoy commented Jul 11, 2024

Release Note Template for Downstream PRs (will be copied)

dlp: added `cloud_storage_target` field to `google_data_loss_prevention_discovery_config` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1282 insertions(+), 43 deletions(-))
google-beta provider: Diff ( 3 files changed, 1282 insertions(+), 43 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 366 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 63
Passed tests: 62
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • datalossprevention

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataLossPreventionDiscoveryConfig_Update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1282 insertions(+), 43 deletions(-))
google-beta provider: Diff ( 3 files changed, 1282 insertions(+), 43 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 366 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 63
Passed tests: 62
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • datalossprevention

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataLossPreventionDiscoveryConfig_Update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataLossPreventionDiscoveryConfig_Update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@patrickmoy
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataLossPreventionDiscoveryConfig_Update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@patrickmoy
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1282 insertions(+), 43 deletions(-))
google-beta provider: Diff ( 3 files changed, 1282 insertions(+), 43 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 366 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 63
Passed tests: 63
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • datalossprevention

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1282 insertions(+), 43 deletions(-))
google-beta provider: Diff ( 3 files changed, 1282 insertions(+), 43 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 366 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 63
Passed tests: 63
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • datalossprevention

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@patrickmoy patrickmoy marked this pull request as ready for review July 11, 2024 14:05
@github-actions github-actions bot requested a review from roaks3 July 11, 2024 14:06
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just a few minor comments

Add tests for GCS terraform
@patrickmoy
Copy link
Member Author

Comments addressed; I'd like to avoid adding those fields as required.

Spacing fixed.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1282 insertions(+), 43 deletions(-))
google-beta provider: Diff ( 3 files changed, 1282 insertions(+), 43 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 366 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 1282 insertions(+), 43 deletions(-))
google-beta provider: Diff ( 3 files changed, 1282 insertions(+), 43 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 366 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 63
Passed tests: 63
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • datalossprevention

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 63
Passed tests: 63
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • datalossprevention

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants