Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct custom import for fields. #11173

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

pcostell
Copy link
Contributor

Use the correct custom import for fields.

Fixes hashicorp/terraform-provider-google#17313.

Verified with a local terraform import followed by terraform plan.

firestore: fixed missing import of `field` for `google_firestore_field`.

Fixes hashicorp/terraform-provider-google#17313.

Verified with a local `terraform import` followed by `terraform plan`.
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 19 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 1 file changed, 19 insertions(+), 16 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 20
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • firestore

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main concern is just that this wasn't caught with the tests, and it looks like we are using ImportStateVerifyIgnore to ignore fields like field. Would you mind removing the ImportStateVerifyIgnore line from the handwritten tests, so that this case is covered? Since you set these fields during import, we don't need to ignore them.

@github-actions github-actions bot requested a review from roaks3 July 18, 2024 03:06
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 28 insertions(+), 28 deletions(-))
google-beta provider: Diff ( 2 files changed, 28 insertions(+), 28 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 20
Passed tests: 20
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • firestore

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@pcostell
Copy link
Contributor Author

ImportVerify sections removed, thanks @roaks3 for pointing those out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing field in google_firestore_field import
3 participants