-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the correct custom import for fields. #11173
Conversation
Fixes hashicorp/terraform-provider-google#17313. Verified with a local `terraform import` followed by `terraform plan`.
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 20 Click here to see the affected service packages
View the build log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main concern is just that this wasn't caught with the tests, and it looks like we are using ImportStateVerifyIgnore
to ignore fields like field
. Would you mind removing the ImportStateVerifyIgnore
line from the handwritten tests, so that this case is covered? Since you set these fields during import, we don't need to ignore them.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 20 Click here to see the affected service packages
View the build log |
ImportVerify sections removed, thanks @roaks3 for pointing those out! |
Use the correct custom import for fields.
Fixes hashicorp/terraform-provider-google#17313.
Verified with a local
terraform import
followed byterraform plan
.