-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optional sql server change tables and transaction logs #11247
feat: optional sql server change tables and transaction logs #11247
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 12 Click here to see the affected service packages
View the build log |
@BBBmau checking in to see if you can review this PR |
mmv1/templates/terraform/examples/datastream_stream_sql_server.tf.erb
Outdated
Show resolved
Hide resolved
994689e
to
a06af09
Compare
a06af09
to
52b65a5
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 12 Click here to see the affected service packages
View the build log |
@nbugden, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required. If no action is taken, this PR will be closed in 28 days. This notification can be disabled with the |
@BBBmau any updates here? Want to be able to close this out. |
@BBBmau can we get an eta on your review? |
apologies for the delay, I'll be taking a look at this today. |
It's worth mentioning also that due to the upcoming 6.0.0 release, I am able to approve but won't be merging until after the major release is done. |
Thanks for calling this out. When is the 6.0.0 release going out? |
6.0.0 is set to be released next monday August 26th |
Thanks! I made the change to |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 12 Click here to see the affected service packages
View the build log |
@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apologies for the late review, everything looks good. thanks for including your debug logs!
Adds optional blocks for
transaction_logs
andchange_tables
to thesql_server_source_config
.Fixes hashicorp/terraform-provider-google#18836
Release Note Template for Downstream PRs (will be copied)