Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional sql server change tables and transaction logs #11247

Conversation

nbugden
Copy link
Contributor

@nbugden nbugden commented Jul 24, 2024

Adds optional blocks for transaction_logs and change_tables to the sql_server_source_config.
Fixes hashicorp/terraform-provider-google#18836

Release Note Template for Downstream PRs (will be copied)

datastream: added `transaction_logs` and `change_tables` to the `datastream_stream` resource

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from BBBmau July 24, 2024 17:47
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 24, 2024
@modular-magician modular-magician added service/datastream and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jul 24, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 93 insertions(+))
google-beta provider: Diff ( 2 files changed, 93 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 44 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 4
Skipped tests: 8
Affected tests: 0

Click here to see the affected service packages
  • datastream

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@nbugden
Copy link
Contributor Author

nbugden commented Jul 26, 2024

@BBBmau checking in to see if you can review this PR

@github-actions github-actions bot requested a review from BBBmau July 30, 2024 12:40
@nbugden nbugden force-pushed the feat/datastream-change-tables-transasction-logs branch from 994689e to a06af09 Compare July 30, 2024 12:40
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 30, 2024
@nbugden nbugden force-pushed the feat/datastream-change-tables-transasction-logs branch from a06af09 to 52b65a5 Compare July 30, 2024 12:42
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 30, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 201 insertions(+))
google-beta provider: Diff ( 2 files changed, 201 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 44 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 4
Skipped tests: 8
Affected tests: 0

Click here to see the affected service packages
  • datastream

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Copy link

@nbugden, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

If no action is taken, this PR will be closed in 28 days.

This notification can be disabled with the disable-automatic-closure label.

@nbugden
Copy link
Contributor Author

nbugden commented Aug 19, 2024

@BBBmau any updates here? Want to be able to close this out.

@nbugden
Copy link
Contributor Author

nbugden commented Aug 20, 2024

@BBBmau can we get an eta on your review?

@BBBmau
Copy link
Collaborator

BBBmau commented Aug 20, 2024

@BBBmau can we get an eta on your review?

apologies for the delay, I'll be taking a look at this today.

@BBBmau
Copy link
Collaborator

BBBmau commented Aug 21, 2024

It's worth mentioning also that due to the upcoming 6.0.0 release, I am able to approve but won't be merging until after the major release is done.

@github-actions github-actions bot requested a review from BBBmau August 21, 2024 01:55
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 21, 2024
@nbugden
Copy link
Contributor Author

nbugden commented Aug 21, 2024

It's worth mentioning also that due to the upcoming 6.0.0 release, I am able to approve but won't be merging until after the major release is done.

Thanks for calling this out. When is the 6.0.0 release going out?

@BBBmau
Copy link
Collaborator

BBBmau commented Aug 21, 2024

It's worth mentioning also that due to the upcoming 6.0.0 release, I am able to approve but won't be merging until after the major release is done.

Thanks for calling this out. When os the 6.0.0 release going out?

6.0.0 is set to be released next monday August 26th

@nbugden
Copy link
Contributor Author

nbugden commented Aug 21, 2024

It's worth mentioning also that due to the upcoming 6.0.0 release, I am able to approve but won't be merging until after the major release is done.

Thanks for calling this out. When os the 6.0.0 release going out?

6.0.0 is set to be released next monday August 26th

Thanks! I made the change to conflicts from exactly_one_of. Can you review in the meantime?
c24b502

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 23, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 201 insertions(+))
google-beta provider: Diff ( 2 files changed, 201 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 44 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 4
Skipped tests: 8
Affected tests: 0

Click here to see the affected service packages
  • datastream

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Copy link

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Collaborator

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apologies for the late review, everything looks good. thanks for including your debug logs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datastream SqlServerSourceConfig missing transactionLogs and changeTables
4 participants